review ghostess

[rosea grammostola]

>
> I see that you use CDBS.  Nice! :-D
>
> Then I suggest to use auto-resolving of build-dependencies (currently they
> are not quite optimal):
>
>  1) copy debian/control to debian/control.in
>  2) edit debian/control.in replacing cdbs build-dpendency with @cdbs@
>  3) invoke the following command to regenerate debian/control:
>
>    DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean
>
>  4) Check what changed in the now auto-updated debian/control
>  5) Remove manual entries from debian/control.in now auto-resolved
>

I don't understand this step. Also it's not always clear when I should do a
step or when CDBS is doing it for me...
I tried to play with it, not sure if I get it for 100% though.



>  6) Repeat steps 3-5 until satisfied
>  6) Commit debian/control.in
>  7) Commit debian/control (separately!)
>
>
> I also suggest to enable tracking of copyright/licensing changes:
>
>  1) Include /usr/share/cdbs/1/rules/utils.mk
>  2) touch debian/copyright_hints
>  3) Invoke the following to generate debian/copyright_newhints:
>
>    DEB_MAINTAINER_MODE=1 debian/rules pre-build
>
>  4) Rename debian/copyright_newhints to debian/copyright_hints
>  5) Commit debian/copyright_hints
>
> After that, at each build the source is scanned for copyright and licensing
> hints, and changes compared to the saved hints file trigger a warning (or a
> failure if DEB_MAINTAINER_MODE=1).
>


I did this step.



>
>
> I also suggest you enable upstream-tarball handling - i.e. a
> get-orig-source build target:
>
>  1) Include /usr/share/cdbs/1/rules/upstream-tarball.mk
>  2) Add hints to get upstream source (have a look inside the actual
> upstream-tarball.mk file, or look at e.g. jackd2 for an example)
>


I skipped this one. To keep it a bit simple for me atm.


I've asked the upstream author to provide a manpage and desktop file.

Regards,

\r
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20100826/e92989fd/attachment-0001.htm>