[SCM] jack-keyboard packaging branch, master, updated. debian/2.5-1-16-g6a0d7c2

[Jonas Smedegaard]

On Mon, Aug 30, 2010 at 08:37:52AM +0000, alessio at users.alioth.debian.org wrote:
>The following commit has been merged in the master branch:
>commit fcd1948a6bfd99b638cb41f0aa6f1bd22d0994db
>Author: Alessio Treglia <alessio at debian.org>
>Date:   Mon Aug 30 10:37:20 2010 +0200
>
>    Install NEWS file as upstream changelog.
>
>diff --git a/debian/rules b/debian/rules
>index 3aee747..e6b51c3 100755
>--- a/debian/rules
>+++ b/debian/rules
>@@ -1,6 +1,7 @@
> #!/usr/bin/make -f
>
> LDFLAGS+=-Wl,--as-needed
>+DEB_INSTALL_CHANGELOGS_ALL = NEWS
>
> include /usr/share/cdbs/1/rules/debhelper.mk
> include /usr/share/cdbs/1/class/autotools.mk


Please beware that NEWS is already included as upstream NEWS.


Also, please list inclusions _above_ variables whenever possible.

Ancient CDBS was picky more about ordering, even of inclusions 
themselves. Now only a few variables must[1] be declared before 
inclusions - please generally list variables below inclusions to 
distinguish the picky from the flexible.



Kind regards,

  - Jonas



[1] Picky variables declared too late should now get detected and cause 
the build to fail with an explicit error about it.

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20100830/d9e09433/attachment.pgp>