RFS: deadbeef (2nd try)

[Paul Tagliamonte]

On Tue, Dec 7, 2010 at 8:47 AM, Alessandro Ghedini <al3xbio at gmail.com> wrote:
> Hi,
>
> On Tue, Dec 07, 2010 at 01:11:34AM +0100, Alessio Treglia wrote:
>> Anyway, I'd shorten the features list just a bit.
>
> Done (I think).
>
>> > P: deadbeef: no-upstream-changelog
>>
>> Easy to fix:
>>
>> override_dh_installchangelogs:
>>         dh_installchangelogs -pdeadbeef ChangeLog
>>
>> > X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/alsa.so.0.0.0
>>
>> It's a common mistake, it had better report this to upstream.
>>
>> > 0.4.4~dfsg-1 might be better phrased as 0.4.4-1~dfsg1
>
> Regarding the lintian errors, I get different results from Paul. Even
> running lintian with -X -E --pedantic (on the changes file) I see no tags
> and manual checking the packages (where possible, for example for the
> missing upstream changelog file) I don't see any problem.
> Maybe you can illuminate me.

I'll just butt in because I posted it :)

The errors were present on your deb files, produced by an Ubuntu natty
pbuilder on Ubuntu maverick, i686, using lintian v2.4.3ubuntu2

>
>> > install should be deadbeef.install
>> > docs should be deadbeef.docs
>>
>> Although unnecessary, these improve the readibility.
>>
>> > manpages should be deadbeef.manpages
>>
>> Maybe needed, I should check.
>
> Done.
>
>> There is a number of subdirectories under plugins/ and some of them
>> seem to contain components already available in Debian.
>> I've found the following ones:
>>
>>  plugins/
>>       mms/
>>       musepack/
>>
>> We should rely on the libraries provided by the system rathen than
>> bring, compile and link against local copies.
>
> I noticed that too, but when I asked to the upstream author if I can safely
> remove them he said that all the bundled libraries have been modified
> by him in a way or another and the software probably wouldn't build/work. I
> didn't investigate further.
>
> I uploaded the corrected version on Debian Mentors.
>
> Thanks
>
> --
> perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
>



-- 
All programmers are playwrights, and all computers are lousy actors.

#define sizeof(x) rand()
:wq