lives review

[Harry Rickards]

2010/1/12 Reinhard Tartler <siretart at tauware.de>:
>
> I have some questions on the lives package:
>
>  - it build depends on
>   frei0r-plugins-dev[!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386 !arm !powerpc],
>
>   However it seems to be available on arm and powerpc:
>
>>> rmadison -u qa frei0r-plugins-dev
> frei0r-plugins-dev | 1.1.22git20090409-2 |       testing | amd64, armel, hppa, i386, ia64, mips, mipsel, powerpc, s390, sparc
> frei0r-plugins-dev | 1.1.22git20090409-2 |      unstable | alpha, amd64, armel, hppa, i386, ia64, mips, mipsel, powerpc, s390, sparc

You're right, it's available on powerpc (I've updated that on Git),
but I don't see it being available on arm.

>   have you tested lives on any of the excluded packages and verified
>   that it does work without frei0r-plugins-dev? If not, I think the
>   arch restrictions can be simplified.

I've tested it builds, but not that it works. I think upstream might
have tested that LiVES (upstream not the Debian package) works without
frei0r-plugins as long as it's not built with frei0r-plugins-dev
though. I'll ask.

>  - lives depends on libdirac-encoder0, and libdirac-decoder0. Should
>   that be pulled in automatically via shlibs?

Yeah. I've updated that in git as well.

>  - it build depends on python. why? I didn't find a check in the
>   configure script for that.

You're right, it shouldn't do. I've updated that in git.

>  - package descriptions could be improved. typos and content-wise.

I'll fix the typos now, and the content later today. Was it just the
misspelling of originally you found?

>  - it seems to be able to use cdda2wav. In debian we have a fork named
>   icedax. Is the current package to use icedax instead of cdda2wav?

Fixed in git.

>  - what limitations does the lives package have without trancode,
>   mencoder and mjpegtools?  All of them are available in ubuntu but not
>   in debian. Perhaps these can be documented in README.Debian.

AFAIK they just allow for extra encoding options, but I'll verify that
with upstream. Once verified I'll add a README.Debian.

Thanks for your help!



-- 
Harry Rickards - harry at linux.com
Debian Lenny server | Debian Sid desktop | UNR Karmic netbook
A good programmer is someone who looks both ways before crossing a
one-way street. - Doug Linder
Binary is as easy as 01, 10, 11.