question on copyright_hint

[IOhannes m zmölnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/25/2010 05:04 PM, Jonas Smedegaard wrote:
> On Wed, Nov 24, 2010 at 09:45:20AM +0100, IOhannes m zmölnig wrote:
>> On 11/24/2010 12:57 AM, IOhannes m zmölnig wrote:
>>> so how should i proceed from here?
>>> - just remove the debian/copyright_hints completely and be happy with
>>> what i got so far?
> 
> You should be _concerned_ with what copyright-check helped you
> discover.  Even if dislike how it works and later trash that routine.

you misunderstood me.
i was not talking about ignoring debian/copyright_hints but instead
about removing the debian/copyright_hints which contains a binary blob.
this is how it is now, btw.

>>> - remove the binary blob from this file? (not so good as the copyright
>>> check relies on copyright_hints being an exact copy of the generated
>>> copyright_newhints (which obviously contains the blob))
> 
> If you mean add build routines to strip the Apple-copyrighted and
> non-licensed part from binary packages?  Then we still ship it with the
> source package which is bad.

no. i was suggesting to edit the copyright_hints file to remove the
binary-blob.
this however was non-feasible, because licensecheck will need an exact
copy of debian/copyright_newhints

>>> - tell CDBS to not copyright check certain files (how?)
> 
> You don't want to do that in this case, as that would be silencing a
> real problem without fixing it.

true

> 
> But the way to do that would be to set (or rather extend)
> DEB_COPYRIGHT_CHECK_IGNORE_REGEX (see /usr/share/cdbs/1/rules/utils.mk
> what it is by default and adapt from there - but i you copy from that
> file then remember to change ?= to = or it won't work: I've lost many
> hours missing that detail).
> 
> 
>>> - file a bug-report in CDBS that it should never create binary-blobs
>>> in the copyright_newhints?
> 
> That's a different issue: changing CDBS does not make these files free.


again, the problem is a 2-fold:
- - binary files containing copyright files (can be fixed by upstream)
- - licensecheck extracts binary blobs from binary files and puts them
into debian/copyright_newhints (must be fixed in licensecheck)

i suggested to file a bugreport because of the 2nd issue (which i know
think is not a cdbs problem but a devscripts (licensecheck) problem)


> 
> But yes, feel free to file a bug-report if you feel it is wrong of CDBS
> to scan non-ASCII chunks, or whatever it is you feel is wrong now (sure
> is to discuss it in a CDBS bugreport than on this list IMHO).
> 
> 
>> not to forget of course:
>> - - exclude the images files alltogether from the orig.tar.gz
>> - - tell upstream to fix the files in question
> 
> Yes, that's the proper approach!

which is done now.

btw, the new files are without the color profiles, thus without
problematic copyrights.
still licensecheck generates a binary blob in debian/copyright_newhints.
i guess it is because it finds "©" and then extracts the "line".

so the (2nd) problem is not fixed even though the problematic files are
fixed.

fgmasdr
IOhannes


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzuoe8ACgkQkX2Xpv6ydvSLdgCfRbDA43k5iqLyFkqq2P9AAk97
Zg8AoLDWKiy7JxjtDIoyjcyIr9i6TzJe
=LZR4
-----END PGP SIGNATURE-----