Bug#596956: FTBFS with Qt 4.7 in experimental

[Alessio Treglia]

Package: hydrogen
Severity: normal
Tags: patch upstream
Forwarded: https://www.assembla.com/spaces/hydrogen/tickets/133-ftbs-with-new-qt-4-7

Hi,


hydrogen fails to build on experimental with the latest Qt 4.7.

g++ -o libs/hydrogen/src/song.o -c -O3 -fomit-frame-pointer -funroll-loops -g -O2 -g -Wall -O2 -DOSS_SUPPORT -DALSA_SUPPORT -DJACK_SUPPORT -DLASH_SUPPORT -DLRDF_SUPPORT -DPORTAUDIO_SUPPORT -DPORTMIDI_SUPPORT -DFLAC_SUPPORT -DLADSPA_SUPPORT -DLIBARCHIVE_SUPPORT -DQT_CORE_LIB -DQT_GUI_LIB -DQT_SHARED -I. -Igui/src -I3rdparty/install/include -Ilibs/hydrogen/include -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui -I/usr/include/lash-1.0 -I/usr/include/alsa libs/hydrogen/src/song.cpp
libs/hydrogen/src/song.cpp: In static member function 'static H2Core::Song* H2Core::Song::get_default_song()':
libs/hydrogen/src/song.cpp:144: error: call of overloaded 'QString(int)' is ambiguous
/usr/include/qt4/QtCore/qstring.h:428: note: candidates are: QString::QString(const QByteArray&)
/usr/include/qt4/QtCore/qstring.h:426: note:                 QString::QString(const char*)
/usr/include/qt4/QtCore/qstring.h:727: note:                 QString::QString(const QString&)
/usr/include/qt4/QtCore/qstring.h:106: note:                 QString::QString(QChar)
/usr/include/qt4/QtCore/qstring.h:105: note:                 QString::QString(const QChar*)
scons: *** [libs/hydrogen/src/song.o] Error 1
scons: building terminated because of errors.
make: *** [debian/stamp-scons-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
I: unmounting dev/pts filesystem
I: unmounting proc filesystem

The following patch solves this issue:

Origin: Ubuntu
Author: David Sugar <david.sugar at canonical.com>
Bug-Ubuntu: https://bugs.launchpad.net/bugs/601195
Description: Fix FTBFS due to an ambiguous overloaded QString object
 constructor.
Forwarded: https://www.assembla.com/spaces/hydrogen/tickets/133-ftbs-with-new-qt-4-7
---
 libs/hydrogen/src/song.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- hydrogen-0.9.4.1.orig/libs/hydrogen/src/song.cpp
+++ hydrogen-0.9.4.1/libs/hydrogen/src/song.cpp
@@ -141,7 +141,7 @@ Song* Song::get_default_song(){
 		song->set_swing_factor( 0.0 );
 
 		InstrumentList* pList = new InstrumentList();
-		Instrument *pNewInstr = new Instrument(QString( 0 ), "New instrument", new ADSR());
+		Instrument *pNewInstr = new Instrument(QString( "" ), "New instrument", new ADSR());
 		pList->add( pNewInstr );
 		song->set_instrument_list( pList );
 		


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash