[SCM] projectm/master: Add patch for projectM crash

Matthias Klumpp matthias at nlinux.org
Sat Sep 25 12:46:12 UTC 2010


Yep, you're right this was a really messy patch...

> On Sa, Sep 25, 2010 at 02:16:34 (CEST),
> ximion-guest at users.alioth.debian.org wrote:
> 
>> The following commit has been merged in the master branch:
>> commit 8d2fdfe1a75ece7cf4891d59286e182ea2f35b75
>> Author: Matthias Klumpp <matthias at nlinux.org>
>> Date:   Sat Sep 25 02:13:35 2010 +0200
>> [patch_content]
> 
> The commit message (but unfortunately not the patch description)
> indicates that this is an attempt to use the 'system' fonts. In this
> case, I think you shouldnt' care about CMAKE_INSTALL_PREFIX, but
> hardcode it to "/usr/share/projectM/fonts/VeraMono.ttf".
I already changed this, but haven't commit it yesterday. (The patch was
from 2 'o clock in the morning, so no wonder why it's broken)

> Otherwise I hardly think this patch is acceptable upstream. Even if we
> keep it local, this patch still makes the hard assumption that
> CMAKE_INSTALL_PREFIX == "/usr"
Hmm, okay. Changed. I set the "Forwarded" key to not-needed too.

> 
>> + 
>> +     #ifdef WIN32
>> diff --git a/debian/patches/series b/debian/patches/series
>> old mode 100644
>> new mode 100755
>> index fc62544..72dddea
>> --- a/debian/patches/series
>> +++ b/debian/patches/series
>> @@ -2,8 +2,9 @@
>>  02_pulseaudio_cmakelist.patch
>>  03_desktop-files.patch
>>  04_pulseaudio_stat.patch
> 
>> -05_libprojectm_fix-cmakelists.patch
>> -06_libprojectm_fonts.patch
>> +05_lprojectm_fix-cmakelists.patch
>> +06_lprojectm_fonts.patch
> 
> This seems unrelated and to and undocumented in this patch
This was in a different patch... Seems like I messed something while
commiting the new patch.

Thanks for the comment!
Btw: There were also some strange new file permissions in this patch. The
new patches fix all issues.
Regards
   Matthias




More information about the pkg-multimedia-maintainers mailing list