Bug#615731: horgand: ftbfs with gold or ld --no-add-needed

[Matthias Klose]

Package: horgand
Version: 1.14-3
Severity: important
Tags: sid
User: peter.fritzsche at gmx.de
Usertags: no-add-needed

The package fails to build in a test rebuild on at least amd64 with
ld --no-add-needed.  For details, please see:
http://lists.debian.org/debian-devel-announce/2011/02/msg00011.html
http://wiki.debian.org/ToolChain/DSOLinking

Ubuntu might have a patch for this issue, but unfortunately it was
not forwarded to Debian.  Please have a look at
http://packages.qa.debian.org/horgand to see if an Ubuntu version for
this package exists, and if a fix is included in the Ubuntu diff.

[...]
make[2]: Entering directory `/build/user-horgand_1.14-3-amd64-VH4rZm/horgand-1.14/src'
make  all-am
make[3]: Entering directory `/build/user-horgand_1.14-3-amd64-VH4rZm/horgand-1.14/src'
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o main.o main.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organ.o organ.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organDSPEffects.o organDSPEffects.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organAudioOut.o organAudioOut.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organMIDIIn.o organMIDIIn.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organAccompaniment.o organAccompaniment.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organvarios.o organvarios.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o organFileIO.o organFileIO.C
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o jackoutput.o jackoutput.C
jackoutput.C: In function 'int JACKstart(HOR*)':
jackoutput.C:47:16: warning: 'jack_client_t* jack_client_new(const char*)' is deprecated (declared at /usr/include/jack/jack.h:105)
jackoutput.C:47:42: warning: 'jack_client_t* jack_client_new(const char*)' is deprecated (declared at /usr/include/jack/jack.h:105)
g++ -DHAVE_CONFIG_H -I.     -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT     -c -o HORGAN.o HORGAN.cxx
g++  -O3 -fno-rtti -pipe -ffast-math -ffunction-sections -fomit-frame-pointer -msse -Wall  -I/usr/include/freetype2   -D_THREAD_SAFE -D_REENTRANT       -o horgand main.o organ.o organDSPEffects.o organAudioOut.o organMIDIIn.o organAccompaniment.o organvarios.o organFileIO.o jackoutput.o HORGAN.o  -lfltk -lasound -ljack -lpthread -lrt   -lsndfile   -lXpm
/usr/bin/ld: HORGAN.o: undefined reference to symbol 'XSetWMHints'
/usr/bin/ld: note: 'XSetWMHints' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[3]: *** [horgand] Error 1
make[3]: Leaving directory `/build/user-horgand_1.14-3-amd64-VH4rZm/horgand-1.14/src'
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
dh_auto_build: make -j1 returned exit code 2
make[2]: Leaving directory `/build/user-horgand_1.14-3-amd64-VH4rZm/horgand-1.14/src'
make[1]: Leaving directory `/build/user-horgand_1.14-3-amd64-VH4rZm/horgand-1.14'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2