[SCM] ffmpeg/master: sanitize LDFLAGS variable

[Jonas Smedegaard]

On Sun, Jan 30, 2011 at 09:07:02AM +0000, siretart at users.alioth.debian.org wrote:
>    sanitize LDFLAGS variable
>
>    it seems that dpkg-buildflags injects -Wl,-Bsymbolic-functions to
>    LDFLAGS, which breaks the build on amd64. The exact cause is unclear,
>    but our current theory is that -Bsymbolic-functions disables -Bsymbolic,
>    on which the build system relies:

Looks like Ubuntu to me - I have not noticed this on Debian, but have 
heard of other similar situations of Ubuntu aggresively applying "funky" 
things by default on their autobuilders.


>
>-# XXX this probably needs fixing
>+# Sanitize injected compiler in linker flags
> CFLAGS :=
>+LDFLAGS :=

Please add a reference to the reasoning in that comment - is seems 
pretty useless as is.

And I strongly recommend to file bugreports to the compile environment 
(Ubuntu, Debian, whatever) which triggers this problem so it does not go 
unnoticed.


  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110130/24d64ab8/attachment-0001.pgp>