Advene package - python2 packaging issues

[Jonas Smedegaard]

On 11-06-20 at 05:56pm, Olivier Aubert wrote:
> With the help of Jonas, I have addressed all comments about the 
> packaging of the Advene application. Is there anything more that 
> should be done to have it uploaded? I am ready to handle all 
> maintenance of the package, but I cannot upload it.

The purpose of debian/changelog is to track releases targeted Debian.  
Please avoid creating multiple sections not reflecting actual releases.


This construct is inelegant:

pre-build::
       cd po; make update-po

Better to a) use && to properly catch errors, and b) use $(MAKE) as 
documented in the documentation of the make language (see 'info make').

So this is better:

pre-build::
       cd po && $(MAKE) update-po

...and related to that (not tested): Make sure that clean rules properly 
cleanup those generated .mo files.


debian/copyright is improperly encoded as DEP-5 format: License filed do 
not allow comma-separation. Multi-line sections must use dot as vertical 
space. Public Domain cannot also be copyrighted. Possible more errors.  
Please carefully read DEP-5 and check that file thoroughly - it is 
arguably the most important file in the packaging!

Is LGPL-3 compatible with GPL-2?  If noone on this list know 
confidently, then please ask at the debian-legal@ mailinglist.

A license PSF is listed, but actual licensing text is missing.

Also, I recommend to move licenses to separate License sections and 
place all those at the bottom of the file, for improved readability.

I notice the package contains SVG files.  It might be beneficial to use 
scour (in Debian package python-scour) to compact them.



Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110620/5c4c42d6/attachment-0001.pgp>