Bug#615742: binutils gold fix for libdrumstick

[Modestas Vainius]

Hello,

On antradienis 01 Kovas 2011 17:28:25 Adrian Knoth wrote:
> On Tue, Mar 01, 2011 at 11:57:13AM +0200, Modestas Vainius wrote:
> 
> Hi!
> 
> > I feel like you are not listening, but it's your right. So until you
> > wake up, Debian maintainer will have to patch libdrumstick. However, I
> > just suggest him doing s/QT_X11_X11_LIBRARY/X11_X11_LIB/ instead of
> > current patch-hack that is of really poor quality and has some bad
> > side effects.
> 
> I've crafted a libdrumstick patch as you suggested:
> 
>   
> http://git.debian.org/?p=pkg-multimedia/libdrumstick.git;a=commitdiff;h=08
> a4577b83269785de0fd2dcd7587a890fdfd6fd
> 
> It works, though I'm by far no cmake expert, so this might not be the
> best solution.

You can omit find_package(X11) as Qt4ConfigDependentSettings.cmake should call 
it [1]. Other than that, it's ok. Ship it!

[1] See /usr/share/cmake-2.8/Modules/Qt4ConfigDependentSettings.cmake:98

-- 
Modestas Vainius <modax at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110301/63c508a4/attachment.pgp>