[SCM] supercollider/master: Fix build, due to restrictions imposed at linking time. Author: Mathieu Trudel-Lapierre

[Dan S]

2011/11/19 Reinhard Tartler <siretart at tauware.de>:
> On Sa, Nov 19, 2011 at 14:30:30 (CET), Felipe Sateler wrote:
>
>> On Sat, Nov 19, 2011 at 07:28, Reinhard Tartler <siretart at tauware.de> wrote:
>>> On Di, Nov 15, 2011 at 11:07:19 (CET), danstowell-guest at users.alioth.debian.org wrote:
>>>
>>>> The following commit has been merged in the master branch:
>>>> commit fd5913d30c0aa53f4666cc4af6e0def3f6eaa8df
>>>> Author: Dan Stowell <danstowell at users.sourceforge.net>
>>>> Date:   Tue Nov 15 09:52:40 2011 +0000
>>>>
>>>>     Fix build, due to restrictions imposed at linking time.
>>>>     Author: Mathieu Trudel-Lapierre
>>>>
>>>> diff --git a/debian/changelog b/debian/changelog
>>>> index 7d27f59..aa60188 100644
>>>> --- a/debian/changelog
>>>> +++ b/debian/changelog
>>>> @@ -1,3 +1,10 @@
>>>> +supercollider (1:3.4.4-3) unstable; urgency=low
>>>> +
>>>> +  * Patch from Mathieu Trudel-Lapierre to fix build under stricter linking.
>>>> +    Closes: #648782
>>>> +
>>>> + -- Dan Stowell <danstowell at users.sourceforge.net>  Tue, 15 Nov 2011 09:54:00 +0000
>>>> +
>>>
>>> As this package showed up on PET and looked easy, I've tried to upload
>>> it. Eventually, I gave up because I failed to create a source package
>>> that I can pass to my pbuilder. Upon further investigation, I noticed
>>> that the package is a) CDBS and b) uses scons and c) runs scons in the
>>> 'clean' target in a way that it makes it fail if development headers
>>> such as libreadline-dev and libicu-dev are missing. I cannot imagine
>>> that the 'clean:' rule really require these packages to fulfill their
>>> jobs.
>>
>> Actually, that is a problem with scons. SCons doesn't distinguish
>> between 'configure' and 'build', so it performs all tests whenever
>> invoked. One can try to hack around this like with Dan's patch, but in
>> the general case scons cannot reliably work unless all the project
>> dependencies are installed (otherwise it might for example not clean
>> up some optional targets because some dependency was missing).
>
> Well, for me that sounds like one shouldn't use scons, at least not in
> the clean: rule of debian/rules.

Well fwiw, supercollider has moved to cmake for the next version, so
our scons stuff is legacy. For that reason, I won't commit that patch
I suggested unless someone here would like to try it and it helps.

Best
Dan


> Thanks for the clarification.
>
> Cheers,
> Reinhard,
>
> --
> Gruesse/greetings,
> Reinhard Tartler, KeyID 945348A4
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers