RFS: screenkey - utility to display pressed keys in screencasts/presentations
Eshat Cakar
info at eshat.de
Sat Oct 15 23:24:52 UTC 2011
Dear Alessandro,
> Here are few notes on your package. Note that I'm not a DD therefore I
> can't upload the package.
thanks a lot for your helpful review on the package.
Please excuse my late response:
> First thing first, the git repository is missing the "pristine-tar" branch,
> please create it (it should be automatically generated by git-import-orig
> using the --pristine-tar flag, or manually using the pristine-tar(1)
> utility). It is also missing an "upstream/0.2" tag (also created by
> git-import-orig).
I had a problem with this, since screenkey is developed by upstream for
ubuntu, it does include a debian folder which seems to cause problems with
pristine-tar. If someone has a solution, I would be happy to pull.
> * debian/chaneglog:
> - This shouldn't mention versions previous to the actual upload to Debian
removed.
> * debian/compat:
> - Any reason why you are not using compat level 8?
No, leftover from ubuntu packaging. Changed.
> * debian/control:
> - The Maintainer field should read "Debian Multimedia Maintainers <...>"
Fixed.
> - The package FTBS: you are missing a Build-Depends on python
Fixed with help from #debian-python
> - You should probably rewrite the short and long descriptions, since they
> are, IMHO, not very helpful
that's true. I replaced it now, but it's surely still not perfect.
I'd be happy, if a native english speaker could have a short look.
> * debian/patches/*:
> - Have a look at DEP3 [1] about "Patch Tagging Guidelines" and please use
> it for your patches
Thanks for the reference. I didn't know there was DEP3. I've made it conform
and will use it in future.
> - You may also want to forward your patches upstream (also valid for the
> manpage).
I'll refer him to gitweb.
> That's all from me, but I may have missed something.
Thanks again.
Best regards,
--
eshat cakar
web: www.eshat.de gpg-id: 799B 95D5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20111016/fc932e24/attachment.pgp>
More information about the pkg-multimedia-maintainers
mailing list