[SCM] pd-zexy/master: preserve autom4te.cache

[Jonas Smedegaard]

On 11-09-29 at 05:45pm, IOhannes m zmoelnig wrote:
> On 2011-09-29 17:06, Reinhard Tartler wrote:
> > On Do, Sep 29, 2011 at 16:45:08 (CEST), IOhannes m zmoelnig wrote:
> >> feel free to review, comment and upload :-)
> > 
> > Still says UNRELEASED in debian/changelog ;-)
> > 
> > at least that would make it appear in pet's "to upload" list.
> 
> huh?
> it seems like i missed something, like "pet" (who? what?) monitoring 
> the state in debian/changelog.

I am surprised too that this team uses PET.  Nice!


> apart from that, i thought that given i am still a "junior packager" 
> i'd rather have a "senior packager", who does the actual upload, 
> change the line from UNRELEASED to unstable.
> 
> if my packages start to be releasable without too much discussion, 
> i'll probably start handing out "unstable" tags :-)

Seems you are confusing two things here:

PET uses debian/changelog suite hint as indication if a package in VCS 
is considered ready to be released.  If ready it is set to a sensible 
suite, if not ready it should be set to UNRELEASED.

Then, when actually releasing, we add a git tag.


So you are right that you should not git-tag before actually releasing, 
but it makes good sense that you change the hinting in changelog when 
you believe the package is ready for release (by someone else, if you 
can or will not do it yourself).



> > As for the other changes, seems there is some CDBS black magic 
> > involved, other
> 
> let's wait for jonas then :-)

I guess the "voodoo" referred to this time around is the added 
build-dependency on autotools-dev.

Debian Policy requires documenting in changelog all packaging changes 
that affect the final installation at the user end - i.e. no need to 
document spelling changes to comments in build scripts, or to document 
changes that got rolled back again or superceded by later changes.

So in this case, you are supposed to document that you added this 
build-dependency.  Yes, CDBS added it automagically for you, but it does 
not mess with changelog for you: that's your responsibility.

autotools-dev is used to pull in up-to-date config.* files at build 
time.



You committed changes to copyright and copyright_hints together.

I recommend to commit auto-generated and manual changes separately.  
That eases eventual later revert or cherry-picking across suites.

A license shortname must be a single word. "MIT/X11 (BSD like)" is not a 
single word.

Also, Public Domain is not a real license nor an ownership, so (in my 
understanding) should only be listed when the sole "license" for a work.

Also, it is recommended to use "Expat" for that license to avoid 
ambiguity: There are multiple licenses labelled MIT.

Also, that license isn't exactly Expat but rather a) a derivation with 
"X Consortium" embedded in it and b) an exception.

Also, I recommend wrapping at 72 chars (not important, just nitpicking).

Also, a trailing space has crept in at "Files: ./configure " (not 
important, just nitpicking).

I therefore suggest using Expat~X as license shortname, and move the 
last paragraph up as part of the file listing, like this:

Files: install-sh
Copyright: 1994, X Consortium
License: Expat~X with X exception
 Except as contained in this notice, the name of the X Consortium shall 
 not be used in advertising or otherwise to promote the sale, use or 
 other dealings in this Software without prior written authorization 
 from the X Consortium.



config.guess, config.sub and some other files do not exactly use GPL-2+ 
as licensing, but adds an Autoconf exception.



Regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110929/c4bda069/attachment.pgp>