Bug#659856: mp4v2: Please bring back metadata API

[Matteo F. Vescovi]

On 14/02/2012 17:25, Fabian Greffrath wrote:
> Am 14.02.2012 16:48, schrieb Matteo F. Vescovi:
>> I've tested your patch and sadly I've got to admit that it fails[1] :-(
>
> Okay, I haven't yet tried it myself, it should just serve as a starting
> point. Maybe some other commit needs to get reverted as well.

Ah, OK.

>> Since the patch modifies the upstream source code, I had to re-pack
>> it, as you can see from the updated name of the package (~dfsg1).
>
> He, what else do you expect a patch to do?! Drop it in debian/patches
> and be done with it, or am I missing something?

If you change the upstream code, adding a file (like your patch does), 
dpkg-source ain't happy at all, because it finds discrepancies between 
the .orig.tar.{gz|bzip2} (created using pristine-tar from the clean 
upstream branch) and the upstream modified with the patch. No good. The 
only way is to re-pack the upstream source tree with the patch applied.
But maybe I'm doing it wrong.

> Cheers,
> - Fabian

Cheers.

-- 
Matteo F. Vescovi
Debian Sponsored Maintainer
GnuPG KeyID: 83B2CF7A