Bug#661725: hydrogen: JACK MIDI sends note-off events instead of note-on

[Roland Mas]

Roland Mas, 2012-02-29 19:46:53 +0100 :

[...]

> With ALSA:
> t0: note-off for the current instrument
> t0: note-on
> t0+length of the current sample: note-off
>
> With JACK:
> t0: note-off for the *previous* instrument
> t0+length of the current sample: note-on for the current instrument

  It occurs to me that there are actually two bugs in there.
1. the lack of the first note-off event for the current sample;
2. the lagging of the events.

Number 1 could be argued not to be a bug; after all, the note-off is
only there as a safety net.  However, number 2 seems to be that the
events that are actually sent lag by one event behind those that are
enqueued, which is why t0 includes the note-off related to the previous
instrument.

Further debugging leads me to the included patch.  I added the note-off
event too (second hunk).  The fix is tested here, but I'd appreciate
upstream review of course :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: off-by-one-in-jackmidi.patch
Type: text/x-diff
Size: 1015 bytes
Desc: Patch fixing off-by-one error
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120229/5e4b8778/attachment.patch>
-------------- next part --------------

Roland.
-- 
Roland Mas

Le weblog enti?rement nu -- http://roland.entierement.nu/
Le photoblog enti?rement net -- http://roland.entierement.net/