Bug#654974: mplayer: FTBFS on hurd-i386

[Samuel Thibault]

Diego Biurrun, le Sat 07 Jan 2012 16:06:01 +0100, a écrit :
> On Sat, Jan 07, 2012 at 03:37:19PM +0100, Samuel Thibault wrote:
> > 
> > mplayer currently FTBFS on hurd-i386 due to missing cdparanoia
> > dependency, and unconditional PATH_MAX usage. The attached patch fixes
> > both.
> 
> PATH_MAX is POSIX, so you should fix Hurd instead, see:
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html

Yes, but flagged as optional, when there is no such fixed hard limit.

Also, the mere existence of PATH_MAX tends to make code buggy,
actually.  See for instance in libmenu/menu_filesel.c, sprintf(b, "%s/",
path); will break whenever one encounters a path which is exactly
PATH_MAX-long.

Samuel