Bug#662695: alsaequal: Please enable hardening flags

[Alessandro Ghedini]

tags 662695 pending
kthxbye

On Mon, Mar 05, 2012 at 09:29:34PM +0100, Simon Ruderich wrote:
> Package: alsaequal
> Severity: important
> Tags: patch
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Dear Maintainer,
> 
> Please consider enabling hardening flags which are a release goal
> for wheezy. For more information please have a look at [1], [2]
> and [3].
> 
> debian/compat is already 9, so hardening flags are enabled by
> default via dpkg-buildflags. The only problem is that the build
> system (Makefile) doesn't respect compiler flags from the
> environment. The attached patch fixes this by updating the
> Makefile.

Just pushed the patch to git (commit f227a25).

> The following patch disables quiet builds so missing flags can be
> detected easily:
> 
>     diff -Nru alsaequal-0.6/debian/rules alsaequal-0.6/debian/rules
>     --- alsaequal-0.6/debian/rules  2012-01-12 21:52:28.000000000 +0100
>     +++ alsaequal-0.6/debian/rules  2012-03-05 21:08:33.000000000 +0100
>     @@ -3,6 +3,9 @@
>      DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
>      LIBDIR = lib/$(DEB_HOST_MULTIARCH)
>     
>     +# Disable quiet builds.
>     +export Q=
>     +
>      %:
>             dh $@
> 

I've pushed this too (commit 37ea84f) so that the build logs are more
informative.

Thank you for your help.

Cheers

-- 
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120305/6a748ea5/attachment.pgp>