x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable

[Jonas Smedegaard]

On 12-03-19 at 09:42am, Andres Mejia wrote:
> On Mon, Mar 19, 2012 at 9:40 AM, Fabian Greffrath 
> <fabian at greffrath.com> wrote:
> > Am 19.03.2012 13:41, schrieb Andres Mejia:
> >
> >> x264 set -O3 by default. Us setting -O2 would have overridden that. 
> >> And with -g, x264 doesn't set -g by default (I presume because full 
> >> optimizations are enabled). Even so, x264 doesn't provide dbg 
> >> packages so there's no use in enabling -g anyway.
> >
> >
> > I see, so you re-set CFLAGS to get rid of certain flags that are 
> > enabled in Debian by default but that the source's build system 
> > should better take care of in these cases. Is this right also for 
> > the other packages where you introduced this change?

> Yes. In particular, I checked if the package's build system sets -O3
> instead of -O2.

Sounds like related to a previous misunderstanding I've had too:

In the past I got the impression that -O2 was sort-of mandatory in 
Debian - but have since learned that unusual optimization is fine (as 
long as it is sensible!), what is mandated by Policy is the ability to 
turn off optimizations.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120319/375369cd/attachment.pgp>