Checking if handbrake compiles under kFreeBSD?

[Pino Toscano]

Hi,

Alle domenica 20 maggio 2012, Rogério Brito ha scritto:
> I'm adding the HURD people here, so that they can test the package
> and see if something should be done or not.
> 
> For the HURD people, this is a reply to [my first e-mail][*] about
> getting the HandBrake ripper/transcoder working on kFreeBSD and
> patches that need to be added for building:
> 
> [*]: http://lists.debian.org/debian-bsd/2012/05/msg00198.html

Thanks for aking, although currently I cannot test it due to libfaac and 
libmp4v2 not being yet available.

Although, I can provide some hints to help.

> > > [2]:
> > > http://anonscm.debian.org/gitweb/?p=pkg-multimedia/handbrake.git
> > > ;a=blob;f=debian/patches/0004-Enable-compilation-on-kFreeBSD-arch
> > > es.patch
> > 
> > The patch seems to work, but I wonder if some of the tests for
> > __FreeBSD_kernel__ should more accurately be testing for !linux and
> > vice-versa.
> > 
> > This doesn't matter for GNU/kFreeBSD, but it could affect future
> > portability to another arch like like GNU/Hurd.
> 
> I hope that the HURD people could let me know about this, so that I
> can fix some potential problems and, if necessary, forward fixes to
> upstream.

Patch 0004 is wrong in a couple of bits:
- gtk/src/callbacks.c:
  udev is not unavailable on win32 and on kfreebsd (but available
  everywhere), but available _only_ on linux; so make the udev code
  compile only on linux
- gtk/configure.ac:
  instead of add a new kfreebsd case, copying as a whole (without gudev)
  the list of pkg-config packages to check, add gudev to the list only
  on linux
attached there is an updated version of patch 0004.

When building, I noticed it wget's from download.handbrake.fr a svn 
snapshot of libdvdread; note this is not acceptable at all in Debian for 
two reasons:
- a package build must use only things available within the sources
  themselves (and of course stuff installed as build dependency too)
- we have libdvdread in Debian already (which has been fixed for Hurd,
  unlike that copy that fails)

Furthermore, please disable (or make it optional) the use of ccache; 
while it may be useful during test builds, it is close to useless when 
doing builds in buildds.

Last, I attached a preliminary version of patch for Hurd support; as 
said above I couldn't go far in the build, although what I have so far 
would seem safe enough.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Enable-compilation-on-kFreeBSD-arches.patch
Type: text/x-patch
Size: 2739 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120524/c20ccb97/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hurd.diff
Type: text/x-patch
Size: 1432 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120524/c20ccb97/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120524/c20ccb97/attachment.pgp>