Bug#720440: mpg123: mpg123 does not build LFS wrappers on kfreebsd-i386

[Reinhard Tartler]

Package: mpg123
Version: 1.15.3-1
Severity: important
Justification: Broken binaries on release architecture kfreebsd-i386

According to the build logs in
https://buildd.debian.org/status/fetch.php?pkg=mpg123&arch=kfreebsd-i386&ver=1.15.3-1&stamp=1365806890,
the configure script determines that off_t has the size 8, which seems
unusual for a 32bit operating system:

checking size of off_t... 8

This causes various compiation warnings later:

lfs_alias.c: In function 'mpg123_decode_frame_32':
lfs_alias.c:123:2: warning: passing argument 2 of 'mpg123_decode_frame'
from incompatible pointer type [enabled by default]
In file included from lfs_alias.c:49:0:
mpg123.h:514:12: note: expected 'off_t *' but argument is of type 'long int *'
lfs_alias.c: In function 'mpg123_framebyframe_decode_32':
lfs_alias.c:131:2: warning: passing argument 2 of
'mpg123_framebyframe_decode' from incompatible pointer type [enabled by default]
In file included from lfs_alias.c:49:0:
mpg123.h:523:12: note: expected 'off_t *' but argument is of type 'long
int *'
lfs_alias.c: In function 'mpg123_feedseek_32':
lfs_alias.c:179:2: warning: passing argument 4 of 'mpg123_feedseek' from
incompatible pointer type [enabled by default]

Also, it breaks the compilation of mplayer2,
cf. https://buildd.debian.org/status/fetch.php?pkg=mplayer2&arch=kfreebsd-i386&ver=2.0-701-gd4c5b7f-2&stamp=1377018444

cc -o mplayer command.o [...] libmpcodecs/vd_xanim.o
libmpcodecs/vd_xvid4.o -Wl,-z,noexecstack  -Wl,-z,relro -L/usr/local/lib
-ffast-math   -lncurses -lsmbclient -lquvi   -lvdpau   -lpng -lz -lmng
-lz -ljpeg -lungif -lpulse   -ljack -lpthread -lrt   -lbluray
-L/usr/lib/i386-kfreebsd-gnu -ldvdread -ldvdread -lcdio_paranoia
-lcdio_cdda -lcdio   -lass   -lenca -lz -lmad -lvorbis -logg -lspeex
-ltheora -logg   -lmpg123   -la52 -ldca -lfaad -lbs2b   -llcms2
-lavutil -lavcodec -lavformat -lswscale   -lpostproc   -lavresample
-ldv -lxvidcore -lm -lvstream-client -lpthread -ldl -rdynamic
-L/usr/lib/i386-kfreebsd-gnu -ldvdnavmini -lpthread  -lm  -ldirectfb
-lXext -lX11 -lpthread -lXss -lXv -lXinerama -lXxf86vm
-L/usr/lib/i386-kfreebsd-gnu -lcaca -lSDL -lGL -ldl -llirc_client
libmpcodecs/ad_mpg123.o: In function `decode_a_bit':
/«PKGBUILDDIR»/libmpcodecs/ad_mpg123.c:278: undefined reference to
`mpg123_decode_frame_64'
collect2: error: ld returned 1 exit status
make[2]: *** [mplayer] Error 1

AFAIU the configure script and the header mpg123.h, the _64 bit vaiants
are expected to be present also on kfreebsd-i386. In case this
assumption is wrong, then mpg123.h should not alias to the _64 variants
on this arch.

Thomas, can you comment on what is the right thing to do on
kfreebsd-i386?

Thanks & Cheers,
Reinhard


Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4