pyliblo_0.9.1-3_amd64.changes REJECTED

[Sebastian Ramacher]

On 2013-08-27 22:42:05, Jaromír Mikeš wrote:
> 2013/8/27 Sebastian Ramacher <sramacher at debian.org>
> 
> >
> > To run the tests, the extensions modules need to be available in
> > PYTHONPATH. Starting with something like the test targets found at
> > https://wiki.debian.org/Python/LibraryStyleGuide, one could use
> >
> > # Callable functions to determine the correct PYTHONPATH
> > pythonpath = $$(ls -d $(CURDIR)/build/lib.*-$(1))
> >
> > ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
> > test-python%:
> >   PYTHONPATH=$(call pythonpath,$*) \
> >     python$* -m unittest discover -s test/ -p '*.py' -v
> >
> > override_dh_auto_test: $(PYTHON2:%=test-python%) $(PYTHON3:%=test-python%)
> > endif
> >
> > (untested)
> >
> >
> tested here:
> 
>    debian/rules override_dh_auto_test
> make[1]: Entering directory `/tmp/buildd/pyliblo-0.9.1'
> make[1]: *** No rule to make target `test-python2.7', needed by
> `override_dh_auto_test'.  Stop.

The attached patch definitely did it for me. Well, except for the test
failure of course.

Regards
-- 
Sebastian Ramacher
-------------- next part --------------
diff --git a/debian/rules b/debian/rules
index 60444d9..9fd4a13 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,7 +8,6 @@ PYTHON3=$(shell py3versions -vr)
 
 build-python%:
 	python$* setup.py build --with-cython
-	debian/tests/python-liblo
 
 override_dh_auto_build: $(PYTHON3:%=build-python%)
 	dh_auto_build
@@ -19,5 +18,15 @@ install-python%:
 override_dh_auto_install: $(PYTHON3:%=install-python%)
 	dh_auto_install
 
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+pythonpath = $$(ls -d $(CURDIR)/build/lib.*-$(1))
+
+test-python%:
+	PYTHONPATH=$(call pythonpath,$*) \
+		python$* -m unittest discover -s test/ -p '*.py' -v
+
+override_dh_auto_test: $(PYTHON2:%=test-python%) $(PYTHON3:%=test-python%)
+endif
+
 override_dh_installchangelogs:
 	dh_installchangelogs NEWS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130828/6f3eb634/attachment.sig>