Bug#720440: mpg123: mpg123 does not build LFS wrappers on kfreebsd-i386

Thomas Orgis thomas-forum at orgis.org
Sat Aug 31 12:26:46 UTC 2013


(I'm also CCing the FreeBSD port maintainer, as I imagine they want that
handled, too.)

Am Sat, 31 Aug 2013 10:03:46 +0200
schrieb Reinhard Tartler <siretart at gmail.com>: 

> Thomas, may I have your opinion on this patch? If you are d'accord,
> I'd upload it to debian/unstable for further testing.

OK, I see that I need to see more clear. The aliases need to be named
_64 and also need to use the correct type for offsets. I didn't design
lfs_alias.c to be so smart to derive the correct type from
LFS_ALIAS_BITS. With your patch, it still would use long arguments,
which I presume should fail at runtime with mplayer2. We need to
change the wrapper's argument to reflect whatever is native to the
platform, not the mpg123 build (it _is_ the same for kFreeBSD).

Please have a read of my musings,

  http://scm.orgis.org/view/mpg123/trunk/doc/LARGEFILE ,

and try the attached patch, which reflects the changes I did in mpg123
trunk, so that you can drop it for mpg123-1.16.0 (which I plan to
release once I got around fixing some decoder build choice).

I kindly ask everyone concerned to really test this on their platform
(including linking and running mplayer2 with mpg123 usage, for
example), as I don't have time to set up test installs for the variants
right now. I did check that the symbols get defined correctly on my
Linux system.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-freebsd-lfs.patch
Type: text/x-patch
Size: 10082 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130831/d825294a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130831/d825294a/attachment.sig>


More information about the pkg-multimedia-maintainers mailing list