Bug#699831: vlc(1) produces --help with ANSI escapes, even if TERM=dumb

[Ivan Shmakov]

Package: vlc-nox
Version: 2.0.3-4

	Even with TERM set to ‘dumb’, vlc(1) and cvlc(1) still try to
	produce a colorful --help output (presumably using some
	hardwired escape sequences) on a TTY.

	This is particularly annoying when running from an
	“application-embedded” Shell (such as Emacs' M-x shell, or
	M-! ⟨command⟩ &), which typically employ a pseudo terminal.

	Consider, e. g. (with ESC's replaced with ^['s):

$ echo "$TERM" 
dumb
$ infocmp 
#	Reconstructed via infocmp from file: /lib/terminfo/d/dumb
dumb|80-column dumb tty,
	am,
	cols#80,
	bel=^G, cr=^M, cud1=^J, ind=^J,
$ cvlc --help 
VLC media player 2.0.3 Twoflower (revision 2.0.2-93-g77aa89e)
Usage: vlc [options] [stream] ...
…
^[[0;1mNo matching module found. Use --list or --list-verbose to list available modules.^[[0m
^[[32;1m
 Audio
^[[0m^[[0;1m      --audio, --no-audio        ^[[0m^[[34;1mEnable audio (default enabled)
$ 

	Naturally, such output should always respect terminfo(5) (or
	termcap(5)) settings, and no attempt should be made to output
	any “fancy” escape sequences that aren't mentioned there.

-- 
FSF associate member #7257