handbrake 0.9.8+dfsg1-2 fails to build in Ubuntu amd64 due to missing prototype.

[Paul Gevers]

Hi Multimedia maintainers,

You might have seen already (some of you responded there) that Ubuntu
builds handbrake from experimental (on my request).

The build on amd64 in Ubuntu is failing because handbrake seems to miss
a proper prototype in libhb/decavcodec.c and libhb/encavcodecaudio.c
(see below). This is to prevent failure on amd64 and ia64 systems.

As I don't have the knowledge yet to provide a proper fix, I rather
thought to let you know. Do you want me to take this up with upstream,
or can one of you provide a patch (I assume it is really simple
actually), and help upstream with that?

See the conversation below where Daniel explains the situation.

Don't hesitate to tell me how I can help here.

Paul

On 20-02-13 12:47, Daniel Holbach wrote:
> Ok, the build log
> (https://launchpadlibrarian.net/130365583/buildlog_ubuntu-raring-amd64.handbrake_0.9.8%2Bdfsg1-2_FAILEDTOBUILD.txt.gz)
> seems to say the following:
> ---------
> Function `av_audio_convert_alloc' implicitly converted to pointer at
> ../libhb/decavcodec.c:1488
> Function `av_audio_convert_alloc' implicitly converted to pointer at
> ../libhb/encavcodecaudio.c:242
> 
> 
> 
> Our automated build log filter detected the problem(s) above that will
> likely cause your package to segfault on architectures where the size of
> a pointer is greater than the size of an integer, such as ia64 and amd64.
> 
> This is often due to a missing function prototype definition.
> 
> Since use of implicitly converted pointers is always fatal to the
> application
> on ia64, they are errors.  Please correct them for your next upload.
> 
> More information can be found at:
> http://wiki.debian.org/ImplicitPointerConversions
> ---------
> 
> That's the reason, why the build worked fine locally, but broke on the
> build daemons. :-)
> 
> Have a great day,
>  Daniel
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 554 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130220/9fd641f2/attachment.pgp>