Bug#699470: crystalhd-dkms: Kernel null pointer BUG in crystalhd_dioq_fetch_wait()

[thomas schorpp]

On 01.03.2013 18:36, Andres Mejia wrote:
> It looks like the crystalhd drivers are buggy with newer kernel
> releases. I opt for removing the dkms package. I will do this over the
> weekend.

Driver is maintainable and supported up to at least Linux 3.8 series, when we'll have 4.0 in debian stable, 2015?

schorpp at tom3:/mnt/data/usr/local/src/crystalhd/driver/linux$ make clean
rm -f *.map *.list *.o *.ko crystalhd.mod.c crystalhd_lnx.o crystalhd_misc.o crystalhd_cmds.o crystalhd_hw.o crystalhd_linkfuncs.o crystalhd_fleafuncs.o crystalhd_flea_ddr.o
schorpp at tom3:/mnt/data/usr/local/src/crystalhd/driver/linux$
schorpp at tom3:/mnt/data/usr/local/src/crystalhd/driver/linux$ make
make -C /lib/modules/3.8.1/build SUBDIRS=/mnt/data/usr/local/src/crystalhd/driver/linux modules
make[1]: Entering directory `/mnt/data/usr/local/src/linux-laststable'
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_lnx.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_misc.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_cmds.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_hw.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_linkfuncs.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_fleafuncs.o
   CC [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd_flea_ddr.o
   LD [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd.o
   Building modules, stage 2.
   MODPOST 1 modules
   CC      /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd.mod.o
   LD [M]  /mnt/data/usr/local/src/crystalhd/driver/linux/crystalhd.ko
make[1]: Leaving directory `/mnt/data/usr/local/src/linux-laststable'
schorpp at tom3:/mnt/data/usr/local/src/crystalhd/driver/linux$

Builds without warnings with my patches.

schorpp at tom3:~$ uname -a
Linux tom3 3.8.1 #12 SMP PREEMPT Fri Mar 1 20:41:00 CET 2013 x86_64 GNU/Linux
schorpp at tom3:~$ hellobcm
starting up
Running DIL (3.22.0) Version
DtsDeviceOpen: Opening HW in mode 0
Clock set to 180
Setting Color Mode to 1
try calls done
Unable to open input file
DtsAllocIoctlData Error
schorpp at tom3:~$ dmesg |grep crystal
[    6.426460] Loading crystalhd v3.10.1
[    6.426515] crystalhd 0000:03:00.0: Starting Device:0x1612
[    6.429600] crystalhd 0000:03:00.0: irq 51 for MSI/MSI-X
[   99.896730] crystalhd 0000:03:00.0: Opening new user[0] handle
[  102.604770] crystalhd 0000:03:00.0: Closing user[0] handle via ioctl with mode 1c200
[  243.648468] crystalhd 0000:03:00.0: Opening new user[0] handle
[  246.325373] crystalhd 0000:03:00.0: Closing user[0] handle via ioctl with mode 1c200
[  334.105537] crystalhd 0000:03:00.0: Opening new user[0] handle
[  336.776957] crystalhd 0000:03:00.0: Closing user[0] handle via ioctl with mode 1c200
[  510.322855] crystalhd 0000:03:00.0: Opening new user[0] handle
[  510.577299] crystalhd 0000:03:00.0: Closing user[0] handle with mode ffffffff
[  510.781740] crystalhd 0000:03:00.0: Opening new user[0] handle
[  511.036308] crystalhd 0000:03:00.0: Closing user[0] handle with mode ffffffff
[  511.240825] crystalhd 0000:03:00.0: Opening new user[0] handle
[  513.801093] crystalhd 0000:03:00.0: [FMT CH] PIB:0 ff 420 6 2d0 162 2d0 0 0 0
[  513.921604] crystalhd 0000:03:00.0: MISSING 3 PICTURES
[  514.587208] crystalhd 0000:03:00.0: Closing user[0] handle via ioctl with mode 1c200
[  535.989772] crystalhd 0000:03:00.0: Opening new user[0] handle
[  536.244314] crystalhd 0000:03:00.0: Closing user[0] handle with mode ffffffff
[  536.448772] crystalhd 0000:03:00.0: Opening new user[0] handle
[  536.703282] crystalhd 0000:03:00.0: Closing user[0] handle with mode ffffffff
[  536.907816] crystalhd 0000:03:00.0: Opening new user[0] handle
[  539.435257] crystalhd 0000:03:00.0: [FMT CH] PIB:0 ff 420 6 2d0 162 2d0 0 0 0
[  539.508317] crystalhd 0000:03:00.0: MISSING 3 PICTURES
[  616.455975] crystalhd 0000:03:00.0: Closing user[0] handle via ioctl with mode 1c200
schorpp at tom3:~$

Loads and runs with Totem and MPlayer.

root at tom3:~# lspci -vvv -s 03:00.0 |grep Sta
     Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR+ <PERR- INTx-
         Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=1 PME-
         DevSta:    CorrErr+ UncorrErr+ FatalErr- UnsuppReq+ AuxPwr- TransPend-
         LnkSta:    Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
         UESta:    DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq+ ACSViol-
         CESta:    RxErr+ BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr+
         Status:    InProgress-
             Status:    NegoPending- InProgress-
root at tom3:~#

Some non-fatal pci errors, but lspci is usually reporting incorrectly here or my old pci-e host is pretty incompatible.

So no technical reasons to drop the package?

y
tom