[Bug 1240227] Re: Sync csound 1:6.00.1~dfsg-2 (universe) from Debian unstable (main)

[Felipe Sateler]

Hi team,

On Mon, Oct 21, 2013 at 6:23 AM, Daniel Holbach
<daniel.holbach at ubuntu.com> wrote:
> This unfortunately fails to build on trusty amd64:
>
> [  2%] Building C object CMakeFiles/csound64.dir/Engine/envvar.c.o
> /usr/bin/x86_64-linux-gnu-gcc  -DCS_DEFAULT_PLUGINDIR=\"/usr/lib/csound/plugins64-6.0\" -DHAVE_STRTOD_L -DHAVE_STRTOK_R -DLINUX -DPIPES -DUSE_DOUBLE -DUSE_LRINT -D_CSOUND_RELEASE_ -D_GNU_SOURCE -Dcsound64_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -DHAVE_ATOMIC_BUILTIN -fPIC -I"/tmp/buildd/csound-6.00.1~dfsg/./H" -I"/tmp/buildd/csound-6.00.1~dfsg/./include" -I"/tmp/buildd/csound-6.00.1~dfsg/./Engine" -I"/tmp/buildd/csound-6.00.1~dfsg/." -I"/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu"     -ftree-vectorize -ffast-math -O3  -mtune=generic  -fvisibility=hidden -Wno-format   -D__BUILDING_LIBCSOUND -DHAVE_PTHREAD_SPIN_LOCK -DHAVE_PTHREAD_BARRIER_INIT -DPARCS -DGNU_GETTEXT -DHAVE_DIRENT_H -DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H -DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -o CMakeFiles/csound64.dir/Engine/envvar.c.o   -c "/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c"
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundParseEnv':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:383:7: error: format not a string literal and no format arguments [-Werror=format-security]
>        csoundMessage(csound, Str(msg));
>        ^
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundGetDirectoryForPath':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:720:7: error: format not a string literal and no format arguments [-Werror=format-security]
>        csoundDie(csound, Str("Current directory path name too long\n"));
>        ^
> cc1: some warnings being treated as errors
> make[3]: *** [CMakeFiles/csound64.dir/Engine/envvar.c.o] Error 1
> make[3]: Leaving directory `/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu'
> make[2]: *** [CMakeFiles/csound64.dir/all] Error 2
>
>
> ** Changed in: csound (Ubuntu)
>        Status: New => Incomplete

I'm trying to get csound synced into Ubuntu, but the build is failing
due to -Werror=format-security. Interestingly, I can't reproduce this
in debian, even if I force add said flag. Possibly some
misconfiguration on my part?

Can any in the team that use Ubuntu help me fix this issue? I'm
currently very low on disk space so am Ubuntu chroot is out of the
question for me.

The fix is simple (just insert a "%s" as second argument in
csoundMessage or CsoundDie). However, since I can't reproduce the
failure, more instances of the problem are likely to be missed.

-- 

Saludos,
Felipe Sateler