Bug#730415: tsdecrypt uses inappropriate build flags including -march=native

[peter green]

Package: tsdecrypt
Severity: serious
Tags: patch
Version: 8.0-1

tsdecrypt's build system appears to assume that the package is being 
built with the intention of running it on the same machine it is being 
built on. As such it uses -march=native and depending on detection code 
sets several other flags.

This is not appropriate for debian. Packages built on debian should run 
on the minimum hardware chosen by the port maintainers regardless of the 
hardware in the machine used to build them. In general the porters 
descisions will be reflected in the defaults that are hardcoded into the 
compiler, Therefore compiler flags that affect the CPU requirements 
should generally only be used to build secondary versions of code for 
use in conjunction with runtime CPU detection. -march=native should 
never be used as it leads to build results that depend on what hardware 
happens to be in the build system.

It appears that this impacts all versions from 8.0-1 to 10.0-1

The attatched debdiff should fix this. I also included a fix for 
incomplete cleanup in the clean target which I noticed while working on 
the fix.

No intent to NMU.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tsdecrypt.debdiff
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20131124/98fef780/attachment.ksh>