Bug#728146: pd-iemambi: FTBFS on kfreebsd-*: #error No byte order defined

[IOhannes m zmoelnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

hi,

On 2013-10-28 22:08, Sebastian Ramacher wrote:
> 
> pd-iemambi fails to build on kfreebsd-* with: | /usr/bin/make  -C
> src CFLAGS="-g -O2 -fstack-protector --param=ssp-buffer-size=4
> -Wformat -Werror=format-security -Wall" CXXFLAGS="-g -O2
> -fstack-protector --param=ssp-buffer-size=4 -Wformat
> -Werror=format-security -Wall" CPPFLAGS="-D_FORTIFY_SOURCE=2"
> LDFLAGS="-Wl,-z,relro" | make[1]: Entering directory
> `/«PKGBUILDDIR»/src' | cc -DPD -DUNIX -W -Wno-unused
> -Wno-parentheses -Wno-switch -funroll-loops -fomit-frame-pointer
> -fno-strict-aliasing -DDL_OPEN -fPIC -g -O2 -fstack-protector
> --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall
> -I. -I/usr/local/src/pd/src  -c -o ambi_decode.o ambi_decode.c | In
> file included from ambi_decode.c:7:0: | iemlib.h:69:2: error:
> #error No byte order defined |  #error No byte order defined |   ^ 
> | make[1]: *** [ambi_decode.o] Error 1
> 
> 
> Full build log is available at 
> https://buildd.debian.org/status/fetch.php?pkg=pd-iemambi&arch=kfreebsd-amd64&ver=0.2-1&stamp=1373234505.

thanks
> 
for the bug-report.

i tried to tackle down the problem and installed a kfreebsd-amd64
system in VirtualBox.
for whatever reasons i'm unable to reproduce the FTBFS.

the problematic code looks like:

<snip>
#if defined(__FreeBSD__) || defined(__APPLE__) ||
defined(__FreeBSD_kernel__)
# include <machine/endian.h>
#endif

#if defined(__unix__) || defined(__APPLE__)
# if !defined(BYTE_ORDER) || !defined(LITTLE_ENDIAN)
#  error No byte order defined
# endif
#endif
</snip>

afaict (using `cpp -dM /dev/null`) both "__FreeBSD_kernel__" and
"__unix__" are defined by default on kfreebsd-amd64.
after including <machine/endian.h> BYTE_ORDER is also defined (at
least according to `cpp -dM /usr/include/machine/endian.h`), so i do
not know how error can be triggered.

could anybody please confirm that it pd-iemambi does (not) build on
their kfreebsd-* systems?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQIcBAEBCAAGBQJScQccAAoJELZQGcR/ejb4Ez0QAJSll6piMds7P15PBzAHauTz
vktEXlrONqxf8P4S1Io9F44+yITxTqt52RBKCnybWoXE7AuFSjbcqkprkQVmiq8j
yluDgL+/z0ojFBL3mKDqqwv6OncVkEgyRd3+d4G2KxDQoZH48/1B2z75PpETovay
Uj2ZEHcDDmhk/hntX/dexovIpn/eVjXSSDq38jQBLegzfR2is0vY5+YZW+FPOC2V
XFb53p5/XFRNMNCubd5E0tfqrcx1kxgtp4ZASbgMnjixdwj9N3WVa3zqDFxoxlZ1
5yaxaWEKuTj6Kz6WRuqOv1fyF1/68ykQnsAKkFm7qXYv8HY/eU4JjaMn6A1cEEtx
lD7mqWNyHtlwht2IjHCFErciRjQWDCOppw3ERyhAlCdXUNwFxRMme05c9SjKn+eJ
ujSKXRMsxJlY8ctaYvcpSMf54+6AgtNu2BhvE0l1njcqK38xAvY7OYmGwfvolZdh
Lw017XtAFeSeahIu2OG8jD7BdtLPIQzYlz5/JrkKMkteOojYpq64T2i4D9PCF2XZ
Y6Hew3qSggQ2Q03Qdp2VWwJ9Ye95Ji/gWsnOFzFFzyKANMSeZa6e0zsxAnI6pCy6
6aNx2WYSLMbi8gMQzDmSRC69EGb0mW4hy5RB+O6O1iy5+AqaoRORp1bnL0KqnR49
C1+Uq/h6NM/YlpV4kvR1
=hUr5
-----END PGP SIGNATURE-----