Bug#723681: libsoundtouch0: breaks ABI on armel

Sebastian Ramacher sramacher at debian.org
Wed Sep 18 20:07:39 UTC 2013


Package: libsoundtouch0
Version: 1.7.1-1
Severity: serious
Tags: sid jessie patch
Control: affects -1 + src:audacity

In version 1.7.1 of soundtouch
|     #if (defined(__SOFTFP__))
|         // For Android compilation: Force use of Integer samples in case that
|         // compilation uses soft-floating point emulation - soft-fp is way too slow
|         #undef  SOUNDTOUCH_FLOAT_SAMPLES
|         #define SOUNDTOUCH_INTEGER_SAMPLES      1
|     #endif
was added to include/STTypes.h [1]. Since __SOFTFP__ is defined on
armel, SAMPLETYPE changed from float to short and the signatures of some
functions changed.

For example, take the following simple program:
| #include <soundtouch/FIFOSampleBuffer.h>
| int main()
| {
|   soundtouch::FIFOSampleBuffer f;
|   soundtouch::SAMPLETYPE s = 0;
|   f.putSamples(&s, 1);
| }

When compiled and linked against a version prior to 1.7.1 and then
upgrading to 1.7.1, the program fails to run:
% ./a.out
./a.out: symbol lookup error: ./a.out: undefined symbol: _ZN10soundtouch16FIFOSampleBuffer10putSamplesEPKfj

The attached patch reverts this change and restores ABI compatibility.

Regards
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: soundtouch-revert.patch
Type: text/x-diff
Size: 718 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130918/f78706c3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130918/f78706c3/attachment.sig>


More information about the pkg-multimedia-maintainers mailing list