[SCM] ardour3/master: Pass env variables to waf

[Felipe Sateler]

On Tue, Sep 24, 2013 at 6:31 PM, Jonas Smedegaard <dr at jones.dk> wrote:
> Quoting fsateler at users.alioth.debian.org (2013-09-24 16:33:18)
>>  DEB_MAKE_EXTRA_ARGS = -v --destdir=$(CURDIR)/debian/tmp
>>  DEB_MAKE_BUILD_TARGET = build i18n_mo
>> +DEB_MAKE_ENVVARS = CFLAGS="$(or $(CFLAGS_$(cdbs_curpkg)),$(CFLAGS))" CXXFLAGS="$(or $(CXXFLAGS_$(cdbs_curpkg)),$(CXXFLAGS))" CPPFLAGS="$(or $(CPPFLAGS_$(cdbs_curpkg)),$(CPPFLAGS))" LDFLAGS="$(or $(LDFLAGS_$(cdbs_curpkg)),$(LDFLAGS))"
>
> Above is needlessly complex (unlike CDBS snippets, this rules file has
> no need for supporting per-package override variables).
>
> This should suffice:
>
>   DEB_MAKE_ENVVARS = CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)"

Indeed, I only did copy paste of it. Also, I expect we will want to
add an i686-optimized and an altivec optimized binary, in which case I
think we will need the per-package flags (please correct me if wrong).

>
> ...but some flags are declared differently in CDBS waf.mk snippet.
> Possibly of relevance...

Unfortunately, the difference is that waf.mk sets LINKFLAGS. But
LDFLAGS works and is (as noted in the page linked by Jaromír) the
correct variable to specify. I suspect LINKFLAGS was used in older waf
(as scons does, I believe they share some ancestry).


--
Saludos,
Felipe Sateler