libde265_0.6-1_amd64.changes REJECTED

[Sebastian Ramacher]

Hi Joachim

On 2014-08-07 09:49:27, Joachim Bauch wrote:
> Dear team,
> 
> On 31.07.2014 12:02, Joachim Bauch wrote:
> [...]
> > I understand. We created a new release that contains all your feedback.
> > 
> > @Alessio: could you (or any other uploader) please review my changes
> > and create/upload a new package of "libde265"?
> > 
> > I updated the git repository on alioth with these changes:
> > - Fixed "debian/watch" to download release tarball, not source tarball.
> > - Updated libde265 to latest upstream version 0.8
> > - Added "libswscale-dev" as build dependency so sherlock265 example
> >   will be compiled.
> > - Reduced amount of exported symbols and updated .symbols file.
> > - Added comment about only the samples being GPL to "debian/copyright".
> [...]
> 
> just a quick follow-up on my last mail. As this is my first package I'm
> not sure if there is anything else I should do, or if I should just wait
> until someone finds some time to upload it.
> Due to the lack of feedback I find it difficult to know if progress is
> stalled because I'm missing some steps, or because everybody is busy
> doing other stuff - which I totally understand ;-)

If Alessio (or someone else) doesn't beat me, here are some points that I'd
like to see fixed before I'd upload it:

 * The build reports

dpkg-gencontrol: warning: Pre-Depends field of package libde265-dev: unknown substitution variable ${misc:Pre-Depends}
dpkg-gencontrol: warning: Depends field of package libde265-dev: unknown substitution variable ${shlibs:Depends}
dpkg-gencontrol: warning: Pre-Depends field of package libde265-dbg: unknown substitution variable ${misc:Pre-Depends}
dpkg-gencontrol: warning: Depends field of package libde265-dbg: unknown substitution variable ${shlibs:Depends}

   That's right. libde265-dev and libde265-dbg don't have them. Please
   remove them from Depends and Pre-Depends.

 * Please use DEP-3 headers for the patch.

 * If I'm not mistaken, the proper capitalization is H.265. Please fix
   the Descriptions in d/control.

 * Please use Priority: optional (except for the -dbg package, which
   should stay Priority: extra).

 * There is no need to pass --quilt to dh. You already use 3.0 (quilt).

 * I'd put README.md into libde265-dev, i.e. rename debian/docs to
   debian/libde265-dev.docs. It doesn't serve much purpose in the
   library package.

 * (This doesn't affect Debian since the files in extra are not used,
   but you should get this addressed upstream: BSD-4-clause and the GPL
   are incompatible (see for an example #744267). So anyone using these
   files instead of another getopt implementation is unable to
   distribute the binaries.)

Cheers
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20140808/caa9bd32/attachment.sig>