Bug#749978: guayadeque: Updated patch

[Damyan Ivanov]

-=| Olly Betts, 13.08.2014 14:22:47 +1200 |=-
> I've fixed the rendering of the lists, and some of the warnings.  I
> haven't seen any crashes in this build, but would welcome wider testing.
> 
> The only problem I saw was that the logo is missing from the splash
> screen/"About" panel.  It looks like it gets loaded from a memory
> stream, but other images are too seem OK, so not sure why this one is a
> problem.  But it's essentially just a cosmetic issue.

That's great, thanks!

I have built the package with this patch and it seems usable. There 
are other cosmetic issues as well - several button-like controls seem 
smaller that they should and the content is cropped (main buttons for 
play/payse, prev, next etc, the star-rating row, the search input 
field, the library scanning progress).

Updating the collection works.

Playback works, but pausing or stopping it crashes with a segfault. 
Here's the backtrace if it could be of some help.


11,44,03: StatusChanged( 1, 0, 0, 0 )

Program received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) bt

Thread 1 (Thread 0x7ffff7f92a40 (LWP 27924)):
#0  0x0000000000000000 in ?? ()
#1  0x0000000000762975 in guTimeLine::Stop (this=0x1d5aa10) at /tmp/buildd/guayadeque-0.3.7~ds0/src/TimeLine.cpp:227
#2  0x00000000005ac1fa in TimerUpdated (timeline=<error reading variable: value has been optimized out>)
    at /tmp/buildd/guayadeque-0.3.7~ds0/src/MediaCtrl.cpp:2578
#3  0x00007ffff5a85703 in g_timeout_dispatch (source=0xdc3f90, callback=<optimized out>, user_data=<optimized out>)
    at /tmp/buildd/glib2.0-2.40.0/./glib/gmain.c:4472
#4  0x00007ffff5a84ce5 in g_main_dispatch (context=0xce7600) at /tmp/buildd/glib2.0-2.40.0/./glib/gmain.c:3064
#5  g_main_context_dispatch (context=context at entry=0xce7600) at /tmp/buildd/glib2.0-2.40.0/./glib/gmain.c:3663
#6  0x00007ffff5a85048 in g_main_context_iterate (context=0xce7600, block=block at entry=1, dispatch=dispatch at entry=1, 
    self=<optimized out>) at /tmp/buildd/glib2.0-2.40.0/./glib/gmain.c:3734
#7  0x00007ffff5a8530a in g_main_loop_run (loop=0x1d5c430) at /tmp/buildd/glib2.0-2.40.0/./glib/gmain.c:3928
#8  0x00007ffff2f35bc7 in IA__gtk_main () at /build/gtk+2.0-zztKf7/gtk+2.0-2.24.24/gtk/gtkmain.c:1257
#9  0x00007ffff72ffb05 in wxGUIEventLoop::DoRun (this=0xe583b0) at ../src/gtk/evtloop.cpp:65
#10 0x00007ffff79dd9e0 in wxEventLoopBase::Run (this=0xe583b0) at ../src/common/evtloopcmn.cpp:78
#11 0x00007ffff799c116 in wxAppConsoleBase::MainLoop (this=0xc745f0) at ../src/common/appbase.cpp:334
#12 0x00007ffff7a32c7d in wxEntry (argc=@0x7ffff7dd7930: 1, argv=<optimized out>) at ../src/common/init.cpp:495
zsh: segmentation fault  gdb guayadeque

(gdb also crashes at this point)

The relevant source is

    224 void guTimeLine::Stop( void )
    225 {
    226     if( m_TimerId )
 *  227         TimerDestroy(); //g_source_remove( m_TimerId );
    228     m_TimerId = 0;
    229     SetState( guTimeLine::NotRunning );
    230 }


Anyway, I think we better have a crashing guayadeque in unstable, than 
an uninstallable one.

Thanks for your efforts, Olly!


 -- dam