Bug#749978: guayadeque: Much better patch

[Olly Betts]

On Thu, Aug 14, 2014 at 11:29:55AM +0300, Damyan Ivanov wrote:
> Below is an additional patch that removes the border from progress 
> controls in the status bar too. It also tries to remove the border 
> around the search input in the media/radio tabs, but for some reason 
> the result is still bordered controls.

Looking at the wxWidgets sources, in src/generic/srchctlg.cpp
wxSearchCtrl::Create() (which the ctor calls) forces a particular border style
upon us:

    // force border style for more native appearance
    style &= ~wxBORDER_MASK;
#ifdef __WXGTK__
    style |= wxBORDER_SUNKEN;
#elif defined(__WXMSW__)
    // Don't set the style explicitly, let GetDefaultBorder() work it out, unl  ess
    // we will get a sunken border (e.g. on Windows 200) in which case we must
    // override with a simple border.
    if (GetDefaultBorder() == wxBORDER_SUNKEN)
        style |= wxBORDER_SIMPLE;
#else
    style |= wxBORDER_SIMPLE;
#endif

We can set the style after construction to avoid this, but the amended style
above is used for the wxSearchTextCtrl inside the wxSearchCtrl, and changing
the style of the wxSearchCtrl after construction isn't passed on to that.  To
me it looks like it is the wxSearchTextCtrl which isn't quite tall enough.

I can reproduce this issue in the "widgets" sample which comes with wxWidgets,
so I've filed a bug upstream:

http://trac.wxwidgets.org/ticket/16422

I think it isn't worth trying to workaround this in guayadeque - it's
essentially cosmetic, and if we somehow adjusted the size, it would likely to
go wrong the other way when that bug gets fixed.

We have a "go" on the wxsqlite3 transition, so I've NMUed wxsqlite3 to
unstable.  So guayadeque can be uploaded now.

If you'd like me to just NMU with my latest patch + Damyan's changes (probably
without the ineffective style changes on the two wxSearchCtrl objects), just
let me know - I'd be happy to do that.

I understand upstream is planning to switch to Qt, but perhaps we should try
to push this patch upstream, as it would be useful for them until they have
achieved a switch over, and it would save us carrying it.  Is someone OK to
do that?  I have another ~80 packages to deal with for the wx transitions,
so I'm afraid I don't really have time to be liaising with upstreams.

Cheers,
    Olly