Bug#772347: xbmc: bashism in /bin/sh script

[Bálint Réczey]

Control: severity -1 important
Control: tags -1 confirmed pending

Hi Raphael,

Thank you for the bug report.

2014-12-06 15:34 GMT+01:00 Raphael Geissert <atomo64 at gmail.com>:
> Package: xbmc
> Severity: serious
> Version: 2:13.2+dfsg1-4
> User: debian-release at lists.debian.org
> Usertags: goal-dash
>
> Hi,
>
> I've ran checkbashisms (from the 'devscripts' package) over the whole
> archive and I found that your package has a /bin/sh script that uses a
> "bashism".
>
> checkbashisms' output:
>> possible bashism in ./usr/bin/xbmc line 81 (should be >word 2>&1):
>>     if which systemd-coredumpctl &> /dev/null; then
>> possible bashism in ./usr/bin/xbmc line 82 (should be >word 2>&1):
>>       systemd-coredumpctl dump -o core xbmc.bin &> /dev/null
Those are bashisms indeed, but they are harmless IMO.
I will include the fix in next upload, but since the package is quite
big I wouldn't like to prepare an upload just to fix this bug.

Cheers,
Balint

>
> Not using bash (or a Debian Policy compliant shell interpreter that doesn't
> provide such an extra feature) as /bin/sh is likely to lead to errors or
> unexpected behaviours. Please be aware that dash is the default /bin/sh.
>
> Please closely examine the above output and the script, and determine
> what the proper severity of the bug is, and adjust it accordingly. If
> it's important or greater please hurry to get this fixed for jessie.
>
> Hints about how to fix bashisms can be found at:
> https://wiki.ubuntu.com/DashAsBinSh
>
> Thanks in advance,
> Raphael Geissert
>