Bug#739613: flac encode crashes if called as a python subprocess
Cedric Andrieu
ced at opensource.wolfsonmicro.com
Thu Feb 20 13:25:20 UTC 2014
Package: flac
Version: 1.3.0-2
Severity: normal
Dear Maintainer,
The jack CD ripper package in debian fails when calling the flac
encoder. This is logged in bug #720782. This happens since the flac
package upgrade to upstream 1.3.0.x
Look at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720782
After some digging, I believe the bug shall be corrected inside flac
which does a divide by zero when not called from a terminal.
file: src/flac/utils.c
function: get_console_width(void)
{
int width = 80;
#if defined _WIN32
width = win_get_console_width();
#elif defined __EMX__
int s[2];
_scrsize (s);
width = s[0];
#elif !defined __ANDROID__
struct winsize w;
if (ioctl(STDOUT_FILENO, TIOCGWINSZ, &w) != -1) width = w.ws_col;
#endif
return width;
}
shoudl be
int get_console_width(void)
{
int width = 80;
[...]
#elif !defined __ANDROID__
struct winsize w;
if (ioctl(STDOUT_FILENO, TIOCGWINSZ, &w) == -1 || w.ws_col == 0 )
width = 80;
else
width = w.ws_col;
#endif
return width;
}
this way we always have a default at 80 chars.
Hope this helps,
Ced
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf
Kernel: Linux 3.12-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages flac depends on:
ii libc6 2.17-97
ii libflac8 1.3.0-2
flac recommends no packages.
flac suggests no packages.
-- no debconf information
More information about the pkg-multimedia-maintainers
mailing list