Bug#756174: jackd2 building without any of the required build flags

[Steve Langasek]

Package: jackd2
Version: 1.9.10+20140610git97e0e80b~dfsg-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu utopic ubuntu-patch

The jackd2 package in Debian unstable does not properly pass dpkg-buildflags
values to waf.  As a result, the package is built without optimizations
(-O2), has no debugging symbols available at build time (-g), and doesn't
use any of the hardening flags that are exported by dpkg-buildflags by
default on Debian.

The first two of these are violation of a policy "should" (10.1), the last
is bad for the security of the package.

The attached patch is a minimally-invasive fix for this, which uses
DEB_MAKE_EXTRA_ARGS to pass the variables to waf.  However, waf is not make,
so this isn't strictly correct.  There is a waf class in cdbs (available
since cdbs 0.4.90); I don't know why you're not using it, perhaps you want
to switch to using that instead.

I would offer a patch to convert the package to dh(1), but considering the
contents of the Uploaders field I suspect it would not be accepted.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jackd2_1.9.10+20140610git97e0e80b~dfsg-1ubuntu1.debdiff
Type: text/x-diff
Size: 1543 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20140726/99bd0a14/attachment-0001.diff>