Bug#756329: vlc: Fix usage of AVFrame to avoid crashes
Benjamin Drung
bdrung at debian.org
Tue Jul 29 19:58:01 UTC 2014
Am Montag, den 28.07.2014, 22:49 +0200 schrieb Andreas Cadhalpun:
> Package: vlc
> Version: 2.1.4-1
> Severity: important
> Tags: patch
>
> Dear Maintainer,
>
> in modules/codec/avcodec/audio.c one finds:
> AVFrame frame;
> memset( &frame, 0, sizeof( frame ) );
>
> According to the documentation of libavutil this is wrong:
> "sizeof(AVFrame) is not a part of the public ABI, so new fields may be
> added to the end with a minor bump."
>
> This code will crash, when used with a different AVFrame at runtime than
> was available at compile-time.
>
> The attached patch fixes this problem.
Thanks for the patch. This is clearly an upstream issue. Can you forward
your patch to upstream to get it integrated into VLC?
--
Benjamin Drung
Debian & Ubuntu Developer
More information about the pkg-multimedia-maintainers
mailing list