Upload rtmidi to unstable?

[Felipe Sateler]

On Mon, Jun 9, 2014 at 3:06 PM, Jaromír Mikeš <mira.mikes at gmail.com> wrote:
> 2014-06-09 15:52 GMT+02:00 Felipe Sateler <fsateler at debian.org>:
>
>> On Sun, Jun 8, 2014 at 7:34 PM, Jaromír Mikeš <mira.mikes at gmail.com>
>> wrote:
>> >
>> >
>> >
>> > 2014-06-09 0:40 GMT+02:00 Jaromír Mikeš <mira.mikes at gmail.com>:
>> >
>> >>
>> >> 2014-06-06 20:13 GMT+02:00 Felipe Sateler <fsateler at debian.org>:
>> >>
>> >>> Alessio, Jaromír,
>> >>>
>> >>> What do you think about uploading rtmidi 2.1 to unstable? It is
>> >>> currently
>> >>> breaking both reverse deps, stk and midisnoop.
>> >>>
>> >>
>> >> I will have a look on this tomorrow.
>> >
>> >
>> > Actually I already checked ... I don't have DM flag for rtmidi so pls go
>> > ahead or make DM flag for me and I will upload ;)
>>
>> I granted DM flag for rtmidi. But before upload please check with the
>> release team so that the required rebuilds of stk and midisnoop do not
>> collide with another transition.
>
>
> Hi Felipe,
>
> I tried build midisnoop against rtmidi-dev 2.1 but got this:

<snip errors>

I managed to build by applying the following patch:

% git diff src/engine.cpp
diff --git a/src/engine.cpp b/src/engine.cpp
index 4051f05..253ae2f 100644
--- a/src/engine.cpp
+++ b/src/engine.cpp
@@ -25,6 +25,9 @@
 #include "engine.h"
 #include "error.h"

+// RtError was renamed to RtMidiError in rtmidi 2.1
+typedef RtMidiError RtError;
+
 // Static functions

 void
@@ -56,9 +59,6 @@ Engine::Engine(QObject *parent):
         case RtMidi::UNIX_JACK:
             driverNames.append(tr("JACK Audio Connection Kit"));
             break;
-        case RtMidi::WINDOWS_KS:
-            driverNames.append(tr("Windows Kernel Streaming"));
-            break;
         case RtMidi::WINDOWS_MM:
             driverNames.append(tr("Windows Multimedia MIDI"));
             break;


The problem is twofold: RtError is now RtMidiError, and the KS api is
gone in RtMidi 2.1.

So midisnoop would require that patch plus a versioned
build-dependency on RtMidi >= 2.1.0~ds0.

Please try out that patch and see if midisnoop works properly.

-- 

Saludos,
Felipe Sateler