Looking for "libde265" package review / sponsor

forum::für::umläute zmoelnig at umlaeute.mur.at
Mon Mar 31 10:19:58 UTC 2014


hi,

i haven't tried to build the package, but just looking at debian/ i have
a few comments:


you are packaging a library, yet you do not have the so-version in the
package name. the binary packages should be named "libde265-1" (or
whatever the current so-version), "libde265-dev",...

see debian policy §8 [1] for info on how to package libraries.

esp. read about creating a .symbols file.

On 2014-03-31 11:15, Joachim Bauch wrote:
> 
> Changes since the last upload:
> - Updated to latest upstream version 0.6
> - Updated "Standards-Version" to 3.9.5
> 

debian/changelog:
 since libde265 is not yet available in Debian, you might shorten the
changelog to a simple
 "Initial release (Closes: #XXXX)"
where XXXX is your ITP-number.
(that is: you should close the ITP bug with the upload; and you don't
need to document changes between versions that got never uploaded...skip
0.5-x)


debian/copyright:
please use the machine-readable debian/copyright format as described in
  http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
your copyright-file is missing the copyright-holders!


debian/*.dirs:
there is no need to explictely mention these directories, as you are
installing into the directories using .install files; (.dirs is mainly
to create empty directories)


debian/watch:
 the "<project>" part in the filemangle options seems to be a leftover.


debian/rules:
 this seems to be an overly complicated rules file; also, is there a
reason to use debhelper-6?
consider switching to CDBS or short-form dh, which should get rid of a
lot of cruft (like "touch" magic).

cheers, and good luck!

fgamsdr
IOhannes



[1] https://www.debian.org/doc/debian-policy/ch-sharedlibs.html



More information about the pkg-multimedia-maintainers mailing list