Bug#748164: Function declaration without parameter type list shadows risk of stack underflow

[Michael Tautschnig]

Package: gmerlin
Version: 1.2.0~dfsg+1-1
Severity: wishlist
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of bg_transcoder_track_get_general_parameters in
transcoder_track.h

http://sources.debian.net/src/gmerlin/1.2.0~dfsg+1-1/include/gmerlin/transcoder_track.h?hl=122#L122

shadows the fact that bg_transcoder_track_get_general_parameters actually
requires an argument:

http://sources.debian.net/src/gmerlin/1.2.0~dfsg+1-1/lib/transcoder_track.c?hl=1437#L1437

Yet none is provided with the call in transcoder_window_preferences:

http://sources.debian.net/src/gmerlin/1.2.0~dfsg+1-1/apps/transcoder/transcoder_window.c?hl=1295#L1295

As, however, the argument isn't used code might execute correctly at present. To
avoid the risk of undefined behaviour the definition of
bg_transcoder_track_get_general_parameters should be fixed.

Best,
Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20140515/bfe0fb55/attachment.sig>