Bug#749385: csound: Conflicting declarations of oscils_set (and others)

[Felipe Sateler]

Hi all, this was reported to csound with an enhanced diagnostics compiler.

I can't look into it now but I thought I would forward it along.

On Mon, May 26, 2014 at 1:34 PM, Michael Tautschnig <mt at debian.org> wrote:
> Package: csound
> Version: 1:6.03.1~dfsg-1
> Usertags: goto-cc
>
> During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
> and pbuilder) the build failed with the following error. Please note that we
> use our research compiler tool-chain (using tools from the cbmc package), which
> permits extended reporting on type inconsistencies at link time.
>
> [...]
> Linking C shared library libcsound64.so
> /usr/bin/cmake -E cmake_link_script CMakeFiles/csound64.dir/link.txt --verbose=1
> /usr/bin/x86_64-linux-gnu-gcc  -fPIC -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -fvisibility=hidden -DHAVE_ATOMIC_BUILTIN -fopenmp -Wl,-z,relro -fopenmp -shared -Wl,-soname,libcsound64.so.6.0 -o libcsound64.so.6.0 CMakeFiles/csound64.dir/Engine/auxfd.c.o CMakeFiles/csound64.dir/Engine/cfgvar.c.o CMakeFiles/csound64.dir/Engine/corfiles.c.o CMakeFiles/csound64.dir/Engine/entry1.c.o CMakeFiles/csound64.dir/Engine/envvar.c.o CMakeFiles/csound64.dir/Engine/extract.c.o CMakeFiles/csound64.dir/Engine/fgens.c.o CMakeFiles/csound64.dir/Engine/insert.c.o CMakeFiles/csound64.dir/Engine/linevent.c.o CMakeFiles/csound64.dir/Engine/memalloc.c.o CMakeFiles/csound64.dir/Engine/memfiles.c.o CMakeFiles/csound64.dir/Engine/musmon.c.o CMakeFiles/csound64.dir/Engine/namedins.c.o CMakeFiles/csound64.dir/Engine/rdscor.c.o CMakeFiles/csound64.dir/Engine/scsort.c.o CMakeFiles/csound64.dir/Engine/scxtract.c.o CMakeFiles/csound64.dir/Engine/sort.c.o CMakeFiles/csound64.dir/Engine/sread.c.o CMakeFiles/csound64.dir/Engine/swritestr.c.o CMakeFiles/csound64.dir/Engine/twarp.c.o CMakeFiles/csound64.dir/Engine/csound_type_system.c.o CMakeFiles/csound64.dir/Engine/csound_standard_types.c.o CMakeFiles/csound64.dir/Engine/csound_data_structures.c.o CMakeFiles/csound64.dir/Engine/pools.c.o CMakeFiles/csound64.dir/InOut/libsnd.c.o CMakeFiles/csound64.dir/InOut/libsnd_u.c.o CMakeFiles/csound64.dir/InOut/midifile.c.o CMakeFiles/csound64.dir/InOut/midirecv.c.o CMakeFiles/csound64.dir/InOut/midisend.c.o CMakeFiles/csound64.dir/InOut/winascii.c.o CMakeFiles/csound64.dir/InOut/windin.c.o CMakeFiles/csound64.dir/InOut/window.c.o CMakeFiles/csound64.dir/InOut/winEPS.c.o CMakeFiles/csound64.dir/InOut/circularbuffer.c.o CMakeFiles/csound64.dir/OOps/aops.c.o CMakeFiles/csound64.dir/OOps/bus.c.o CMakeFiles/csound64.dir/OOps/cmath.c.o CMakeFiles/csound64.dir/OOps/diskin2.c.o CMakeFiles/csound64.dir/OOps/disprep.c.o CMakeFiles/csound64.dir/OOps/dumpf.c.o CMakeFiles/csound64.dir/OOps/fftlib.c.o CMakeFiles/csound64.dir/OOps/goto_ops.c.o CMakeFiles/csound64.dir/OOps/midiinterop.c.o CMakeFiles/csound64.dir/OOps/midiops.c.o CMakeFiles/csound64.dir/OOps/midiout.c.o CMakeFiles/csound64.dir/OOps/mxfft.c.o CMakeFiles/csound64.dir/OOps/oscils.c.o CMakeFiles/csound64.dir/OOps/pstream.c.o CMakeFiles/csound64.dir/OOps/pvfileio.c.o CMakeFiles/csound64.dir/OOps/pvsanal.c.o CMakeFiles/csound64.dir/OOps/random.c.o CMakeFiles/csound64.dir/OOps/remote.c.o CMakeFiles/csound64.dir/OOps/schedule.c.o CMakeFiles/csound64.dir/OOps/sndinfUG.c.o CMakeFiles/csound64.dir/OOps/str_ops.c.o CMakeFiles/csound64.dir/OOps/ugens1.c.o CMakeFiles/csound64.dir/OOps/ugens2.c.o CMakeFiles/csound64.dir/OOps/ugens2a.c.o CMakeFiles/csound64.dir/OOps/ugens3.c.o CMakeFiles/csound64.dir/OOps/ugens4.c.o CMakeFiles/csound64.dir/OOps/ugens5.c.o CMakeFiles/csound64.dir/OOps/ugens6.c.o CMakeFiles/csound64.dir/OOps/ugtabs.c.o CMakeFiles/csound64.dir/OOps/ugrw1.c.o CMakeFiles/csound64.dir/OOps/ugrw2.c.o CMakeFiles/csound64.dir/OOps/vdelay.c.o CMakeFiles/csound64.dir/OOps/compile_ops.c.o CMakeFiles/csound64.dir/Opcodes/babo.c.o CMakeFiles/csound64.dir/Opcodes/bilbar.c.o CMakeFiles/csound64.dir/Opcodes/compress.c.o CMakeFiles/csound64.dir/Opcodes/eqfil.c.o CMakeFiles/csound64.dir/Opcodes/Vosim.c.o CMakeFiles/csound64.dir/Opcodes/pitch.c.o CMakeFiles/csound64.dir/Opcodes/pitch0.c.o CMakeFiles/csound64.dir/Opcodes/spectra.c.o CMakeFiles/csound64.dir/Opcodes/ambicode1.c.o CMakeFiles/csound64.dir/Opcodes/sfont.c.o CMakeFiles/csound64.dir/Opcodes/grain4.c.o CMakeFiles/csound64.dir/Opcodes/hrtferX.c.o CMakeFiles/csound64.dir/Opcodes/loscilx.c.o CMakeFiles/csound64.dir/Opcodes/minmax.c.o CMakeFiles/csound64.dir/Opcodes/pan2.c.o CMakeFiles/csound64.dir/Opcodes/arrays.c.o CMakeFiles/csound64.dir/Opcodes/phisem.c.o CMakeFiles/csound64.dir/Opcodes/hrtfopcodes.c.o CMakeFiles/csound64.dir/Opcodes/stackops.c.o CMakeFiles/csound64.dir/Opcodes/vbap.c.o CMakeFiles/csound64.dir/Opcodes/vbap1.c.o CMakeFiles/csound64.dir/Opcodes/vbap_n.c.o CMakeFiles/csound64.dir/Opcodes/vbap_zak.c.o CMakeFiles/csound64.dir/Opcodes/vaops.c.o CMakeFiles/csound64.dir/Opcodes/ugakbari.c.o CMakeFiles/csound64.dir/Opcodes/harmon.c.o CMakeFiles/csound64.dir/Opcodes/pitchtrack.c.o CMakeFiles/csound64.dir/Opcodes/partikkel.c.o CMakeFiles/csound64.dir/Opcodes/shape.c.o CMakeFiles/csound64.dir/Opcodes/tabsum.c.o CMakeFiles/csound64.dir/Opcodes/crossfm.c.o CMakeFiles/csound64.dir/Opcodes/pvlock.c.o CMakeFiles/csound64.dir/Opcodes/fareyseq.c.o CMakeFiles/csound64.dir/Opcodes/modmatrix.c.o CMakeFiles/csound64.dir/Opcodes/scoreline.c.o CMakeFiles/csound64.dir/Opcodes/modal4.c.o CMakeFiles/csound64.dir/Opcodes/physutil.c.o CMakeFiles/csound64.dir/Opcodes/physmod.c.o CMakeFiles/csound64.dir/Opcodes/mandolin.c.o CMakeFiles/csound64.dir/Opcodes/singwave.c.o CMakeFiles/csound64.dir/Opcodes/fm4op.c.o CMakeFiles/csound64.dir/Opcodes/moog1.c.o CMakeFiles/csound64.dir/Opcodes/shaker.c.o CMakeFiles/csound64.dir/Opcodes/bowedbar.c.o CMakeFiles/csound64.dir/Opcodes/gab/tabmorph.c.o CMakeFiles/csound64.dir/Opcodes/gab/hvs.c.o CMakeFiles/csound64.dir/Opcodes/gab/sliderTable.c.o CMakeFiles/csound64.dir/Opcodes/gab/newgabopc.c.o CMakeFiles/csound64.dir/Opcodes/ftest.c.o CMakeFiles/csound64.dir/Opcodes/hrtfearly.c.o CMakeFiles/csound64.dir/Opcodes/hrtfreverb.c.o CMakeFiles/csound64.dir/Opcodes/cpumeter.c.o CMakeFiles/csound64.dir/Opcodes/gendy.c.o CMakeFiles/csound64.dir/Opcodes/tl/sc_noise.c.o CMakeFiles/csound64.dir/Opcodes/afilters.c.o CMakeFiles/csound64.dir/Top/argdecode.c.o CMakeFiles/csound64.dir/Top/csdebug.c.o CMakeFiles/csound64.dir/Top/cscore_internal.c.o CMakeFiles/csound64.dir/Top/cscorfns.c.o CMakeFiles/csound64.dir/Top/csmodule.c.o CMakeFiles/csound64.dir/Top/csound.c.o CMakeFiles/csound64.dir/Top/getstring.c.o CMakeFiles/csound64.dir/Top/main.c.o CMakeFiles/csound64.dir/Top/new_opts.c.o CMakeFiles/csound64.dir/Top/one_file.c.o CMakeFiles/csound64.dir/Top/opcode.c.o CMakeFiles/csound64.dir/Top/threads.c.o CMakeFiles/csound64.dir/Top/utility.c.o CMakeFiles/csound64.dir/Top/threadsafe.c.o CMakeFiles/csound64.dir/Top/server.c.o CMakeFiles/csound64.dir/Opcodes/ambicode.c.o CMakeFiles/csound64.dir/Opcodes/bbcut.c.o CMakeFiles/csound64.dir/Opcodes/biquad.c.o CMakeFiles/csound64.dir/Opcodes/butter.c.o CMakeFiles/csound64.dir/Opcodes/clfilt.c.o CMakeFiles/csound64.dir/Opcodes/cross2.c.o CMakeFiles/csound64.dir/Opcodes/dam.c.o CMakeFiles/csound64.dir/Opcodes/dcblockr.c.o CMakeFiles/csound64.dir/Opcodes/filter.c.o CMakeFiles/csound64.dir/Opcodes/flanger.c.o CMakeFiles/csound64.dir/Opcodes/follow.c.o CMakeFiles/csound64.dir/Opcodes/fout.c.o CMakeFiles/csound64.dir/Opcodes/freeverb.c.o CMakeFiles/csound64.dir/Opcodes/ftconv.c.o CMakeFiles/csound64.dir/Opcodes/ftgen.c.o CMakeFiles/csound64.dir/Opcodes/gab/gab.c.o CMakeFiles/csound64.dir/Opcodes/gab/vectorial.c.o CMakeFiles/csound64.dir/Opcodes/grain.c.o CMakeFiles/csound64.dir/Opcodes/locsig.c.o CMakeFiles/csound64.dir/Opcodes/lowpassr.c.o CMakeFiles/csound64.dir/Opcodes/metro.c.o CMakeFiles/csound64.dir/Opcodes/midiops2.c.o CMakeFiles/csound64.dir/Opcodes/midiops3.c.o CMakeFiles/csound64.dir/Opcodes/newfils.c.o CMakeFiles/csound64.dir/Opcodes/nlfilt.c.o CMakeFiles/csound64.dir/Opcodes/oscbnk.c.o CMakeFiles/csound64.dir/Opcodes/pluck.c.o CMakeFiles/csound64.dir/Opcodes/repluck.c.o CMakeFiles/csound64.dir/Opcodes/reverbsc.c.o CMakeFiles/csound64.dir/Opcodes/seqtime.c.o CMakeFiles/csound64.dir/Opcodes/sndloop.c.o CMakeFiles/csound64.dir/Opcodes/sndwarp.c.o CMakeFiles/csound64.dir/Opcodes/space.c.o CMakeFiles/csound64.dir/Opcodes/spat3d.c.o CMakeFiles/csound64.dir/Opcodes/syncgrain.c.o CMakeFiles/csound64.dir/Opcodes/ugens7.c.o CMakeFiles/csound64.dir/Opcodes/ugens9.c.o CMakeFiles/csound64.dir/Opcodes/ugensa.c.o CMakeFiles/csound64.dir/Opcodes/uggab.c.o CMakeFiles/csound64.dir/Opcodes/ugmoss.c.o CMakeFiles/csound64.dir/Opcodes/ugnorman.c.o CMakeFiles/csound64.dir/Opcodes/ugsc.c.o CMakeFiles/csound64.dir/Opcodes/wave-terrain.c.o CMakeFiles/csound64.dir/Opcodes/stdopcod.c.o CMakeFiles/csound64.dir/Opcodes/socksend.c.o CMakeFiles/csound64.dir/Opcodes/sockrecv.c.o CMakeFiles/csound64.dir/Opcodes/ifd.c.o CMakeFiles/csound64.dir/Opcodes/partials.c.o CMakeFiles/csound64.dir/Opcodes/psynth.c.o CMakeFiles/csound64.dir/Opcodes/pvsbasic.c.o CMakeFiles/csound64.dir/Opcodes/pvscent.c.o CMakeFiles/csound64.dir/Opcodes/pvsdemix.c.o CMakeFiles/csound64.dir/Opcodes/pvs_ops.c.o CMakeFiles/csound64.dir/Opcodes/pvsband.c.o CMakeFiles/csound64.dir/Opcodes/pvsbuffer.c.o CMakeFiles/csound64.dir/Opcodes/pvsgendy.c.o CMakeFiles/csound64.dir/Opcodes/dsputil.c.o CMakeFiles/csound64.dir/Opcodes/pvadd.c.o CMakeFiles/csound64.dir/Opcodes/pvinterp.c.o CMakeFiles/csound64.dir/Opcodes/pvocext.c.o CMakeFiles/csound64.dir/Opcodes/pvread.c.o CMakeFiles/csound64.dir/Opcodes/ugens8.c.o CMakeFiles/csound64.dir/Opcodes/vpvoc.c.o CMakeFiles/csound64.dir/Opcodes/pvoc.c.o CMakeFiles/csound64.dir/Opcodes/mp3in.c.o CMakeFiles/csound64.dir/InOut/libmpadec/layer1.c.o CMakeFiles/csound64.dir/InOut/libmpadec/layer2.c.o CMakeFiles/csound64.dir/InOut/libmpadec/layer3.c.o CMakeFiles/csound64.dir/InOut/libmpadec/synth.c.o CMakeFiles/csound64.dir/InOut/libmpadec/tables.c.o CMakeFiles/csound64.dir/InOut/libmpadec/mpadec.c.o CMakeFiles/csound64.dir/InOut/libmpadec/mp3dec.c.o CMakeFiles/csound64.dir/csound_orclex.c.o CMakeFiles/csound64.dir/csound_orcparse.c.o CMakeFiles/csound64.dir/csound_prelex.c.o CMakeFiles/csound64.dir/Engine/csound_orc_semantics.c.o CMakeFiles/csound64.dir/Engine/csound_orc_expressions.c.o CMakeFiles/csound64.dir/Engine/csound_orc_optimize.c.o CMakeFiles/csound64.dir/Engine/csound_orc_compile.c.o CMakeFiles/csound64.dir/Engine/new_orc_parser.c.o CMakeFiles/csound64.dir/Engine/symbtab.c.o CMakeFiles/csound64.dir/Engine/cs_new_dispatch.c.o CMakeFiles/csound64.dir/Engine/cs_par_base.c.o CMakeFiles/csound64.dir/Engine/cs_par_orc_semantic_analysis.c.o CMakeFiles/csound64.dir/Engine/cs_par_dispatch.c.o -lsndfile -lpthread -lm -ldl
>
> error: conflicting function declarations "oscils_set"
> old definition in module entry1 file /srv/jenkins-slave/workspace/sid-goto-cc-csound/csound-6.03.1~dfsg/./H/oscils.h line 67
> signed int (void *)
> new definition in module oscils file /srv/jenkins-slave/workspace/sid-goto-cc-csound/csound-6.03.1~dfsg/OOps/oscils.c line 67
> signed int (struct CSOUND_ *csound, OSCILS *p)
> CMakeFiles/csound64.dir/build.make:5631: recipe for target 'libcsound64.so.6.0' failed
> make[3]: *** [libcsound64.so.6.0] Error 64
>
> Review the definition, which makes heavy use of the second parameter, here
>
> http://sources.debian.net/src/csound/1:6.03.1~dfsg-1/OOps/oscils.c?hl=67#L67
>
> with the conflicting declaration here
>
> http://sources.debian.net/src/csound/1:6.03.1~dfsg-1/H/oscils.h?hl=67#L67
>
> The other functions declared here indeed seem to have the same issue. It is
> hoped that there are other measures in place to ensure the appropriate arguments
> are passed once called via the jumptable set up here:
>
> http://sources.debian.net/src/csound/1:6.03.1~dfsg-1/Engine/entry1.c?hl=836#L836
>
> If this is the case, the declarations in oscils.h should omit the parameter
> lists entirely to make no false claims.
>
> Best,
> Michael
>
>
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers



-- 

Saludos,
Felipe Sateler