Bug#765341: more information

[Martin Steghöfer]

El 21/10/14 a les 14:13, Klaumi Klingsporn ha escrit:
> sorry for the late answer

No need to apologize, you've been a great help so far!


El 21/10/14 a les 16:10, Klaumi Klingsporn ha escrit:
> and I also added the
> configure flag '--with-lv2=system' to Debian/rules

...which I think is a good idea, independently of the current problems. 
I'd suggest that the package maintainers do the same, if there is no 
specific reason not to.

> In audacity-2.0.6/src/effects/lv2/LV2Effect.cpp I found your comment
> from the wxWidgets-3.patch:
> "   // wxWidgets calls OnTextCtrl during creation
>     // of the text control, and LadspaEffectDialog::OnTextCtrl calls
> HandleText,
>     // which assumes all the fields have been initialized.
>     // This can give us a bad pointer crash, so manipulate inSlider to
>     // no-op HandleText during creation. "

This is already very close. :-)

But actually the comment wasn't added by my wxWidgets patch, but was 
there before. And it's not the problem, but the solution. It's a 
workaround that has been in several effect dialogs to avoid a crash on 
Windows. Starting from wxWidgets 3.0 this workaround is necessary for 
GTK, too. In fact, the wxWidgets patch already activated it for the 
LadspaEffectDialog, but neither for the VampEffectDialog nor the 
LV2EffectDialog.

The attached patch (wxwidgets-effect-dialogs-segfault.patch) now does it 
for those, too. Again, I also re-attached the patches for the other 
problems you mentioned in this report.

Cheers,
Martin

P.S.: Depending on the plugin parameters, those LV2 dialogs look really 
ugly (empty space in weird places, empty boxes,...). But that's 
something unrelated to the library upgrade and has to be improved for 
the next upstream version, not in this Debian bug.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: workaround-wxwidgets-fit-recovery.patch
Type: text/x-diff
Size: 2382 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20141021/3bfb2d97/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wxwidgets-clipboard-reentry-workaround.patch
Type: text/x-diff
Size: 3384 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20141021/3bfb2d97/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wxwidgets-effect-dialogs-segfault.patch
Type: text/x-diff
Size: 1781 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20141021/3bfb2d97/attachment-0005.patch>