Bug#749659: audacity + wxWidgets 3.0 — Proposing patch

[Martin Steghöfer]

Hi Reinhard!

Thanks for looking into this issue!


On 09/09/2014 04:12 AM, Reinhard Tartler wrote:
> I wonder what's the status of this bug. The most recent email did not
> help to clarify,

I'm sorry, I guess the side discussions didn't help to understand the 
situation, so here a quick summary:

The patches work fine on the tested platforms, although we agreed on 
making a slight modification to assure its cross-platform compatibility, 
proposed by Olly: Doing a cast instead of a modified format specifier in 
the wxString::Format changes.

So we're basically waiting for a maintainer to incorporate the patches 
(including the modification) in the package, update the build 
dependencies and upload the whole thing. Olly proposed to NMU the 
package, but there was no reaction from any of the maintainers so far.

If it helps, I can post a new version of the patch including Olly's 
proposed change. Would that help?

The maintainers should also decide if they want to accept the configure 
script patch or if they want to modify the package so autoconf 
automatically recreates them.

Bottom-line: The main work is done, but in order to move forward we need 
some attention from the maintainers.

> I guess that is because the build dependencies needs updating. So I guess given that the proposed patch to the package is incomplete at best

The patch is complete.

After applying the patch, the package can build with both wx2.8 and 
wx3.0. But, of course, if you want to build it against wx3.0 then you 
need the wx3.0 dev package installed, which you can assure by updating 
the build dependencies. But that's not part of a patch because we're not 
patching upstream code to do that. That's a modification in the 
debian/control file of the Debian package.

> Martin, may I recommend you getting in touch with
> upstream about this patch?

I am in touch. The transition to wx3.0 isn't a priority there at the 
moment, so this hasn't received a lot of attention, but a very quick 
review from their side approved the proposed patch for wxGTK. But as I 
elaborated in my first message in this bug report, for the Windows and 
Mac ports there's more to it. We're working on that (it requires a lot 
of attention from wxWidgets upstream), but that shouldn't be of interest 
for this issue in Debian.

I hope that helps to clarify the situation! :-)

Cheers,
Martin