Bug#783191: cdbs: allow reusing debian/copyright Files-Excluded for get-orig-source

[Felipe Sateler]

Package: cdbs
Severity: wishlist
X-Debbugs-CC: pkg-multimedia-maintainers at lists.alioth.debian.org

On 23 April 2015 at 11:03, Jonas Smedegaard <dr at jones.dk> wrote:
> Hi Adrian,
>
> Quoting Adrian Knoth (2015-04-23 15:46:55)
>> On 04/23/15 15:03, mira-guest at users.alioth.debian.org wrote:
>>> +# Path to the debian directory
>>> +DEBIAN_DIR := $(shell echo ${MAKEFILE_LIST} | awk '{print $$1}' | xargs dirname )
>>> +UPSTREAM_VERSION ?=$(shell uscan --dehs | sed -n 's/.*<upstream-version>\(.*\)<\/upstream-version>.*/\1/p')
>>> +DFSG = dfsg1
>>> +PKG = $(shell dpkg-parsechangelog | sed -ne 's/^Source: //p')
>>> +
> [...]
>>> +get-orig-source:
>>> +     uscan --noconf --force-download --rename --download-current-version --destdir=.
>>> +     tar -xf $(PKG)_$(UPSTREAM_VERSION).orig.tar.gz
>>> +     mv ardour-$(UPSTREAM_VERSION) $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/waf
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/.git
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/.gitignore
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/MSVCvst_scan
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/MSVCardour3
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/icons/win32/resource
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)/icons/win32/msvc_resources.rc.in
>>> +     XZ_OPT=-9 tar cJf ../$(PKG)_$(UPSTREAM_VERSION)~$(DFSG).orig.tar.xz $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)
>>> +     rm -rf $(PKG)-$(UPSTREAM_VERSION)~$(DFSG)
>>> +     rm -rf $(PKG)_$(UPSTREAM_VERSION).orig.tar.gz
>>
>> This looks overly complicated. In jackd2, Jonas did:
>>
>> # Set tag to full 40 char git tag for git snapshot release
>> tag = $(DEB_UPSTREAM_TARBALL_VERSION)
>> DEB_UPSTREAM_URL = https://github.com/jackaudio/jack2/archive
>> DEB_UPSTREAM_TARBALL_BASENAME = $(tag)
>> DEB_UPSTREAM_TARBALL_SRCDIR = jack2-$(tag)
>>
>> # unneeded and possibly sourceless binaries
>> DEB_UPSTREAM_REPACKAGE_EXCLUDES += *.a *.dll *.Lib
>>
>> # unneeded sources copyright-protected without licence
>> DEB_UPSTREAM_REPACKAGE_EXCLUDES += ./windows/**.rc
>>
>> # pure garbage in upstream tarball
>> DEB_UPSTREAM_REPACKAGE_EXCLUDES += .DS_Store
>>
>> # sources not in prefered form of modification
>> DEB_UPSTREAM_REPACKAGE_EXCLUDES += ./waf
>>
>>
>>
>> Can't we do the same for ardour? Just declare some excludes and let CDBS
>> do the work?
>>
>> Jonas, is this still state of the art? If so, I'd add it to ardour.
>
> Yes, seems up-to-date.

I think specifying it only once in debian/copyright would be a good idea.

Perhaps set a flag DEB_REPACKAGE_AUTOPOPULATE_EXCLUDES = 1 which
causes cdbs to parse debian/copyright?



-- 

Saludos,
Felipe Sateler