Request for review & inclusion: supercollider-sc3-plugins (see RFP #807364)

[Hanno Zulla]

Hi there,

> Please build with dh $@ --parallel if possible.

fixed.

> I: supercollider-sc3-plugins source: duplicate-short-description
> supercollider-sc3-plugins supercollider-sc3-plugins-scsynth
> supercollider-sc3-plugins-sclang
> I: supercollider-sc3-plugins-scsynth:
> extended-description-is-probably-too-short

should be fixed.

> W: supercollider-sc3-plugins source: outdated-autotools-helper-file
> source/StkUGens/stk-4.4.4/config/
>
> This is from the embedded copy of stk.

upstream has removed stk as an embedded copy per request.

> This needs an update for the new location of nova-simd.

fixed & repacked. (Correctly repacked?)

> W: supercollider-sc3-plugins-scsynth: binary-without-manpage
> usr/bin/ladspalist
>
> If the package is providing plugins to supercollider, should this
> binary really be on $PATH?

As discussed on IRC, it's unclear to me where to place this binary.

LADSPA plugins can be used through one of the supercollider sc3 ugen
plugins provided by this package.

The binary only lists those LADSPA plugins available to the user.

I'm not sure where else to put it but in /usr/bin. Packaging it in a
separate .deb seems like overkill. Please advise.

man page will follow soon, no problem.

> I: supercollider-sc3-plugins-sclang: package-contains-empty-directory
> usr/share/SuperCollider/Extensions/SC3plugins/local/
>
> Is this empty directory needed?

no, removed.

> Do the three packages suppercollider-sc3-plugins,
> supercollider-sc3-plugins-scsynth and
> supercollider-sc3-plugins-sclang work in
> any version combination should the dependencies by versioned?

They should be versioned. Do I have to mention the explicit version
number in debian/control or is there a placeholder for it?

> If supercollider-sc3-plugins is just an empty metapackage, please put
> it in the correct section.

fixed.

> Why do you install upstream's TODO?

fixed, removed.

> gbp buildpackage -uc -us -S
> gbp:error: Pristine-tar couldn't checkout
"supercollider-sc3-plugins_3.7.0~beta+git20151221.f978dc2~repack.orig.tar.xz"

Please try again, I restarted the github repo once more.

If that still doesn't work, please advice me on what I did wrong there
and how to fix it.

In the meantime, you can use the
debian/rules get-orig-source
recipe to have the tarball fetched from upstream & repacked.

> Never use an epoch unless you really have to. And you don't have to,
> since this was never in the Debian archive.

I have removed the epoch for now, but do want to put it in:

The package was in an Ubuntu PPA where a different versioning had been
used so far and I would want to override that. Also, Debian's
supercollider already uses an epoch and the sc3 plugins follow
supercollider's version scheme.


Thanks so far,

Hanno