Seeking for sponsorship for linuxptp (PTP/IEEE1588 implementation)

[Tino Mettler]

On Wed, 2015-02-18 at 22:46 +0100, "IOhannes m zmölnig (Debian/GNU)"
wrote:

> me too (and I am personally interested in ptp packages).
> however, i would welcome it if the package would be team-maintained
> under the pkg-multimedia umbrella.

Hi,

thanks for the offer.

> 
> anyhow, i'm currently doing a quick review of the package.
> some notes:
> 
> - i very much prefer to build the package using git(-buildpackage) to
> just buliding packages from mentors.d.n, as this is my proven toolchain
> to build in a chroot environment.
> i am not a gitpkg user though, so i need some help, which you already
> provide in the debian/README.source (thanks for that!).
> unfortunately the information therein is not sufficient (and the
> pristine-tar line mentioning "syncevolution" is rather suspicious).
> i cloned http://tikei.de/git/linuxptp-debian.git and setup the
> quilt-patches hook; but running `gitpkg master` gives me the following
> error:
> 
> ~~~
> $ gitpkg master
> git archive exporting master
> preparing ../deb-packages/linuxptp/linuxptp-1.5
> dpkg-source -b linuxptp-1.5
> dpkg-source: info: using source format `3.0 (quilt)'
> dpkg-source: info: building linuxptp using existing
> ./linuxptp_1.5.orig.tar.gz
> patching file makefile
> Reversed (or previously applied) patch detected!  Skipping patch.
> 1 out of 1 hunk ignored
> dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
> dpkg-source: info: if patch
> '0001-Adjust-installation-directory-for-Debian.patch' is correctly
> applied by quilt, use 'quilt refresh' to update it
> dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b
> -B .pc/0001-Adjust-installation-directory-for-Debian.patch/
> --reject-file=- <
> linuxptp-1.5.orig.zcTD_d/debian/patches/0001-Adjust-installation-directory-for-Debian.patch
> gave error exit status 1

There is a git config command missing in the instructions, sorry for
this:

$ git config gitpkg.pre-export-hook /usr/share/gitpkg/hooks/pristine-tar-pre-export-hook

I'll add this to README.source.

> - as this package has never been in debian before, you can trim the
> debian/changelog to a bare minimum (that is: a single section for
> "1.5-1" [sic!])

Ok, I'm fine with that. 

> - there's a typo in README.Debian: "I also uses eth0" should probably
> read "It also uses eth0".
> it also might make a bit more sense to use "eth1" in the example (as the
> example you give does changes the behaviour to the original one :-))

I'll look into this.

> - debian/rules
> there seems to be some cruft at the beginning of the file.
> e.g. why don't you just use `dpkg-parsechangelog -S Source` to get the
> srcpackage name?
> also you go through some hoops to parse the upstream-version from the
> debian/changelog, but then you hardcode UPSTREAMTAG to "upstream/1.5".
> most likely you can delete lines 3..8

Yes, this is caused due to c&p from another package I took over and as I
removed the lines that used these variables, the lines are now pure
cruft. I'll remove them.

> - configuration files:
> any reasons you don't put all configuration files into /etc/ptp4l/ ?

I looked into the Fedora package and used the same location. Upstream
has no default config file location.

> this might allow you to replace the override_dh_auto_install cruft by a
> simple debian/install file (but this might rename the /etc/ptp4l.conf to
> /etc/ptp4l/default.conf)

I'll look into this.

Thanks for all the comments. I'll send a follow-up if after I pushed the
changes.

Regards,
Tino