Bug#778866: RE: read in movie-title failing

Alessio Treglia alessio at debian.org
Mon Feb 23 12:43:05 UTC 2015


Hi Sean,

I haven't seen your e-mail before, sorry about that.
Thanks for the patch, though I'd prefer to set #!/bin/bash as shebang
rather than applying your patch though as there's plenty of bashisms
in the whole script:

alessio at soqtl021:~/devel/videotrans/src$ checkbashisms -f -n -p -x
movie-title.in
possible bashism in movie-title.in line 97 (echo -n):
    echo -n "`shellescape "$@"` "
possible bashism in movie-title.in line 205 (test -a/-o):
if [ -e "${OUTPUT}" -a ! -f "${OUTPUT}" ]
possible bashism in movie-title.in line 283 (test -a/-o):
if [ "${xx}" = "720" -a "${yy}" = "576" ]
possible bashism in movie-title.in line 287 (test -a/-o):
elif [ "${xx}" = "720" -a "${yy}" = "480" ]
possible bashism in movie-title.in line 305 (test -a/-o):
    if [ "${animated}" != "animated" -a "${animated}" != "static" -a \
            "${animated}" != "none" ]
possible bashism in movie-title.in line 525 (test -a/-o):
    if [ "${animated}" = "animated" -a "${num_title_frames}" -gt "1" ]
possible bashism in movie-title.in line 530 (test -a/-o):
    elif [ "${num_title_frames}" = "1" -a "${audio_length}" -gt "0" \
            -a "${animated}" = "animated" ]
possible bashism in movie-title.in line 694 (test -a/-o):
elif [ "${audio_length}" -gt "0" -a "${animated}" = "animated" ]
possible bashism in movie-title.in line 800 (echo -n):
        echo -n "." >&2
possible bashism in movie-title.in line 879 (test -a/-o):
    if [ "${num_title_frames}" = "1" -a "${audio_length}" -gt "0" -a \
            "${animated}" != "animated" ]
possible bashism in movie-title.in line 1395 (test -a/-o):
    if [ "${num_title_frames}" = "1" -a "${audio_length}" = "0" ]

Cheers.

-- 
Alessio Treglia          | www.alessiotreglia.com
Debian Developer         |     alessio at debian.org
Ubuntu Core Developer    |  quadrispro at ubuntu.com
0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A



More information about the pkg-multimedia-maintainers mailing list