Bug#789754: musescore: FTBFS on architectures with unsigned char

[Edmund Grimley Evans]

Source: musescore
Version: 2.0.1+dfsg-2
Tags: patch

It is failing to build on several architectures with errors like:

/«BUILDDIR»/musescore-2.0.1+dfsg/libmscore/element.h:48:18: error: enumerator value -1 is outside the range of underlying type 'char'

See https://buildd.debian.org/status/package.php?p=musescore&suite=sid

Here's a "patch":

perl -i -pe 's/char/signed char/ if /^enum class (Grip|NoteCaseType) : char/;' \
`find -name '*.h'`

One might want to change some other enums to signed char, for
consistency, but that "patch" is sufficient, it seems. Tested on
arm64.


((
I think there's another problem, not so easy to reproduce, some kind
of race condition that can occasionally result in:

Error copying file "[...]/musescore-2.0.1+dfsg/all.h" to "[...]/musescore-2.0.1+dfsg/build.release/all.h".

But I doubt that's worth investigating. If it became a frequent
problem one could presumably just disable parallel building.
))