Bug#785186: csladspa: Update to version 6.05 crashes finch

[Felipe Sateler]

On 13 May 2015 at 11:35, Fabian Greffrath <fabian at greffrath.com> wrote:
> Am Mittwoch, den 13.05.2015, 11:11 -0300 schrieb Felipe Sateler:
>> AFAICT, csladspa handles the empty case, so that should be ok. But it
>> would be great if you could try both a valid path (any path will do)
>> and an empty string.
>
> It does
>
> src = strdup(getenv("LADSPA_PATH"));
>
> in frontends/csladspa/csladspa.cpp which will inevitably crash if
> LADSPA_PATH is unset, because in that case getenv() returns NULL instead
> of a pointer to "".

That is exactly what I was trying to test (I'm not on my debian
workstation ATM). Note that strdup(NULL) is undefined so this may well
have worked (and returned NULL, which is correctly handled) in the
past.



-- 

Saludos,
Felipe Sateler